Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken MIR impl_trait_in_bindings ICE #57201

Closed
DutchGhost opened this issue Dec 29, 2018 · 2 comments · Fixed by #69842
Closed

Broken MIR impl_trait_in_bindings ICE #57201

DutchGhost opened this issue Dec 29, 2018 · 2 comments · Fixed by #69842
Labels
A-impl-trait Area: impl Trait. Universally / existentially quantified anonymous types with static dispatch. A-mir Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-bug Category: This is a bug. E-needs-test Call for participation: writing correctness tests F-impl_trait_in_bindings `#![feature(impl_trait_in_bindings)]` glacier ICE tracked in rust-lang/glacier I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@DutchGhost
Copy link
Contributor

DutchGhost commented Dec 29, 2018

#![feature(impl_trait_in_bindings)]

fn bug<'a, 'b, T>()
where
    'a: 'b,
{
    let f: &impl Fn(&'a T) -> &'b T = &|x| x;
}

fn main() {}
Backtrace:
error: internal compiler error: broken MIR in DefId(0/0:3 ~ playground[1f65]::bug[0]) (_1 = &(*_2)): bad assignment (&impl std::ops::Fn<(&T,)> = &[closure@src/main.rs:7:40: 7:45]): NoSolution
 --> src/main.rs:7:39
  |
7 |     let f: &impl Fn(&'a T) -> &'b T = &|x| x;
  |                                       ^^^^^^

thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', src/librustc_errors/lib.rs:324:17
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:39
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:70
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:58
             at src/libstd/panicking.rs:200
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:215
   4: rustc::util::common::panic_hook
   5: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:482
   6: std::panicking::begin_panic
   7: <rustc_errors::Handler as core::ops::drop::Drop>::drop
   8: core::ptr::real_drop_in_place
   9: core::ptr::real_drop_in_place
  10: core::ptr::real_drop_in_place
  11: <scoped_tls::ScopedKey<T>>::set
query stack during panic:
end of query stack

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.33.0-nightly (60e825389 2018-12-28) running on x86_64-unknown-linux-gnu

note: compiler flags: -C opt-level=3 -C codegen-units=1 --crate-type bin

note: some of the compiler flags provided by cargo are hidden

https://play.rust-lang.org/?version=nightly&mode=release&edition=2018&gist=ee8dad3e86ef11986e22202b078b2f4b

ICE's on both 2015 and 2018.

This is verry similar to #57200, (notice the & in front of the type and closure here), yet a verry different ICE message.

@matthewjasper matthewjasper added A-NLL Area: Non Lexical Lifetimes (NLL) A-impl-trait Area: impl Trait. Universally / existentially quantified anonymous types with static dispatch. labels Dec 29, 2018
@Centril Centril added the I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ label Dec 29, 2018
@gralpli
Copy link
Contributor

gralpli commented Dec 31, 2018

Came across what looks to be the same ICE today and found a simpler example:

#![feature(impl_trait_in_bindings)]

fn main() {
    let a = vec![1, 2, 3];
    
    let b: Box<impl Iterator> = Box::new(a.iter());
}
error: internal compiler error: broken MIR in DefId(0/0:3 ~ playground[6d86]::main[0]) (Terminator { source_info: SourceInfo { span: src/main.rs:6:33: 6:51, scope: scope[1] }, kind: _5 = const <std::boxed::Box<T>>::new(move _6) -> [return: bb9, unwind: bb7] }): call dest mismatch (std::boxed::Box<impl std::iter::Iterator> <- std::boxed::Box<std::slice::Iter<'_, i32>>): NoSolution
 --> src/main.rs:6:49
  |
6 |     let b: Box<impl Iterator> = Box::new(a.iter());
  |                                                 ^

@matthewjasper matthewjasper self-assigned this Jan 23, 2019
@nikomatsakis nikomatsakis removed the A-NLL Area: Non Lexical Lifetimes (NLL) label Jan 23, 2019
@matthewjasper matthewjasper removed their assignment May 31, 2019
@jonas-schievink jonas-schievink added A-mir Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2019
@Centril Centril added F-impl_trait_in_bindings `#![feature(impl_trait_in_bindings)]` requires-nightly This issue requires a nightly compiler in some way. labels Jul 28, 2019
@rust-lang-glacier-bot rust-lang-glacier-bot added the glacier ICE tracked in rust-lang/glacier label Oct 15, 2019
@Alexendoo
Copy link
Member

Fixed by #67681

@Alexendoo Alexendoo added the E-needs-test Call for participation: writing correctness tests label Feb 16, 2020
Centril added a commit to Centril/rust that referenced this issue Mar 9, 2020
@bors bors closed this as completed in 7e903f8 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-impl-trait Area: impl Trait. Universally / existentially quantified anonymous types with static dispatch. A-mir Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-bug Category: This is a bug. E-needs-test Call for participation: writing correctness tests F-impl_trait_in_bindings `#![feature(impl_trait_in_bindings)]` glacier ICE tracked in rust-lang/glacier I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ requires-nightly This issue requires a nightly compiler in some way. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants