Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Pinning documentation #58130

Closed
RalfJung opened this Issue Feb 3, 2019 · 1 comment

Comments

Assignees
No one assigned
Labels
C-enhancement T-doc
Projects
None yet
Milestone
No milestone
2 participants
@RalfJung @jonas-schievink
@RalfJung
Copy link
Member

RalfJung commented Feb 3, 2019 •
edited

In #55766, it was determined that pinning should be better documented before being stabilized. Yet, stabilization happened without resolving many of the documentation concerns spelled out or writing down the answer given in

Cc @cramertj @withoutboats

@jonas-schievink jonas-schievink added C-enhancement T-doc labels Feb 3, 2019

@RalfJung RalfJung referenced this issue Feb 19, 2019

Merged

improve Pin documentation #58574

@RalfJung

This comment has been minimized.

Sign in to view
Copy link
Member Author

RalfJung commented Feb 19, 2019

I am proposing expanded documentation in #58574, please help proof-reading that!

bors added a commit that referenced this issue Feb 22, 2019

@bors
Auto merge of #58574 - RalfJung:pin, r=Mark-Simulacrum 
improve Pin documentation

Incorporates a bunch of the documentation-related comments that came up when discussing `Pin` stabilization.

Cc @alexcrichton @withoutboats @cramertj @jonhoo

Fixes #58130
Loading status checks…
c6fd027

@bors bors closed this in #58574 Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.