Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions in libbacktrace_sys use malloc/free/realloc directly #60599

Open
glandium opened this issue May 7, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@glandium
Copy link
Contributor

commented May 7, 2019

It's unfortunate that the functions in libbacktrace_sys go around the #[global_allocator] and uses the system allocator directly. That said, I'm not sure what those functions are used for. They don't seem to be used by the panic code.

Cc: @SimonSapin

@glandium

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@SimonSapin

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

@glandium

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Maybe?

@alexcrichton

This comment has been minimized.

Copy link
Member

commented May 8, 2019

This is currently "intentional" in the sense that these functions are referenced from libbacktrace which we don't have a lot of source control over. We could perhaps update the library to take allocation callbacks, but the eventual end goal is to use something like gimli anyway so we wouldn't have this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.