crater run to estimate impact of full NLL transition #60680
In the @rust-lang/lang meeting today, we were saying it'd be a good idea to do a crater run against full NLL just to get a rough idea of how many affected crates there will be.
There are two ways we could do this and both have some value:
triage: this is an important task, but not one that I find should be prioritized over the various bugs currently plaguing the compiler.
Marking as P-medium.
I'm not sure why @Centril nominated it. Its possible that they nominated it solely for prioritization. Or its possible they wanted it to get attention from the compiler team. I'm going to leave the nomination tag on for now, with the understanding, that if we do discuss it at the T-compiler meeting and manage to assign it to someone, then we can remove the nomination tag.
This was referenced
May 17, 2019
Copying triage results over from each PR:
There is some overlap between these 2 categories: so this PR impacted around 130 root crates. I remember a lot of those from the previous crater runs, with legit errors — some of them fixed in more recent versions of the crates (including semver-compatible releases only requiring a
discussed in lang team meeting.
The overall set of regressions was not a deal breaker for the people present in the meeting.
One trend we noted with the listed regressions is that a lot of the problems are coming from ... "old crates", and the main point will be "yep, someone needs to update their dependencies."
So, as part of that, is that we want to write a blog post discussing the overall plan here. in particular, we want to discuss the overall migration to NLL, stating that NLL is coming for every Rust edition, and then saying that the final transition (to hard errors) is fixing soundness bugs. So, part of that post will present a representative sample of real world code with bugs that are being detected by NLL.
(I am taking on the job of writing the aforementioned post; @nikomatsakis is going to provide guidance about where the post will end up being published; i.e. what forum is most appropriate for it. I plan to have the post ready in time for the next Rust release.)