Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
regression: rustdoc resolution changes #61560
I can repro on
This suggests a rustdoc change that detects more tests rather than resolution changes.
Started failing in
In this case, I think the old tests did not compile, but that wasn't easy to see until this version of rustdoc actually started testing them.
Puzzling, the code in the specific
@pnkfelix what do you want to do with this issue ?
As a summary, it seems we have a mix of real rustc bugs, rustdoc effectively-breaking-changes-for-the-better testing new code, and invalid tests. The rustc bugs seem fixed, and the rustdoc behaviour change is #61562, and there might be miscommunication between rustdoc and rustc for the
If need be, I could extract the doctests and bisect those to rustc commits, but I'm not sure we need to ?
As summarized earlier, this issue collects other issues, which were at the intersection of
While we could bisect those problems to look for possible missing test cases, it's likely to point at known issues since they were all fixed either in previous betas of the same crater run or 2-3 releases ago, it doesn't seem absolutely necessary to do so. So let's close this one.