Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for map_ok and map_err method for Poll<Option<Result<T, E>>> #63514

Closed
2 tasks done
95th opened this issue Aug 13, 2019 · 6 comments
Closed
2 tasks done

Tracking issue for map_ok and map_err method for Poll<Option<Result<T, E>>> #63514

95th opened this issue Aug 13, 2019 · 6 comments

Comments

@95th
Copy link
Contributor

@95th 95th commented Aug 13, 2019

Currently map_ok and map_err methods are given for Poll<Result<T, E>>.

We should provide similar methods for Poll<Option<Result<T, E>>> as they are helpful in stream building code.


Steps

  • Implementation: #63512
  • Stabilization

Open questions

None

@mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Apr 27, 2020

Any plans to stabilize this?

Loading

@m-ou-se m-ou-se changed the title Provide map_ok and map_err method for Poll<Option<Result<T, E>>> Tracking issue for map_ok and map_err method for Poll<Option<Result<T, E>>> Dec 8, 2020
@m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Dec 8, 2020

There aren't any open questions about this feature, and this has seen quite a few releases already. So it looks like this would be ready for stabilization.

@rfcbot merge

Loading

@rfcbot
Copy link

@rfcbot rfcbot commented Dec 8, 2020

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Loading

@rfcbot
Copy link

@rfcbot rfcbot commented Dec 9, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

Loading

@rfcbot
Copy link

@rfcbot rfcbot commented Dec 19, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

Loading

JohnTitor added a commit to JohnTitor/rust that referenced this issue Jan 16, 2021
…Simulacrum

Stabilize the poll_map feature

Stabilizes the `poll_map` feature as tracked by rust-lang#63514 (with a completed FCP).
m-ou-se added a commit to m-ou-se/rust that referenced this issue Jan 16, 2021
…Simulacrum

Stabilize the poll_map feature

Stabilizes the `poll_map` feature as tracked by rust-lang#63514 (with a completed FCP).
m-ou-se added a commit to m-ou-se/rust that referenced this issue Jan 16, 2021
…Simulacrum

Stabilize the poll_map feature

Stabilizes the `poll_map` feature as tracked by rust-lang#63514 (with a completed FCP).
@KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jan 22, 2021

This was stabilized in #80968

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants