Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include! should allow inner doc comments and directives #66920

Open
joshtriplett opened this issue Dec 1, 2019 · 1 comment

Comments

@joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented Dec 1, 2019

Currently, include! cannot include a file that contains inner doc comments (//! ...) or directives (#![...]). That creates a challenge when trying to generate a crate's top-level contents with a build script.

See https://internals.rust-lang.org/t/include-raw-directive-for-raw-textual-inclusion-of-generated-code/11405 for discussion. @dtolnay pointed out that we can fix this backwards-compatibly, as it would just turn an error into a non-error.

@Centril

This comment has been minimized.

Copy link
Member

@Centril Centril commented Dec 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.