Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly 2019-12-29 causes `reached the type-length limit` error in previously working code #67757

Closed
sdroege opened this issue Dec 31, 2019 · 3 comments

Comments

@sdroege
Copy link
Contributor

@sdroege sdroege commented Dec 31, 2019

cargo bisect-rustc considers 3a087ad the culprit.

Can be reproduced on https://github.com/sdroege/async-tungstenite by running cargo test:

error: reached the type-length limit while instantiating `std::thread::LocalKey::<std::cel...ure::Future, ()}]>, ()}]>]], ()>`
    |
    = note: consider adding a `#![type_length_limit="1364215"]` attribute to your crate

error: aborting due to previous error

error: could not compile `async-tungstenite`.
warning: build failed, waiting for other jobs to finish...
error: reached the type-length limit while instantiating `async_task::utils::abort_on_pani..., async_std::task::task::Task>]>`
  --> /home/slomo/.cargo/registry/src/github.com-1ecc6299db9ec823/async-task-1.1.1/src/utils.rs:8:1
   |
8  | / pub(crate) fn abort_on_panic<T>(f: impl FnOnce() -> T) -> T {
9  | |     struct Bomb;
10 | |
11 | |     impl Drop for Bomb {
...  |
20 | |     t
21 | | }
   | |_^
   |
   = note: consider adding a `#![type_length_limit="1363798"]` attribute to your crate

error: aborting due to previous error

error: could not compile `async-tungstenite`.
warning: build failed, waiting for other jobs to finish...
error: reached the type-length limit while instantiating `std::thread::LocalKey::<std::cel...::Message>>, ()}]>, ()}]>]], ()>`
    |
    = note: consider adding a `#![type_length_limit="1367031"]` attribute to your crate

error: aborting due to previous error

error: could not compile `async-tungstenite`.
@jonas-schievink

This comment has been minimized.

Copy link
Member

@jonas-schievink jonas-schievink commented Dec 31, 2019

Presumably due to #65244. cc @seanmonstar

@pnkfelix

This comment has been minimized.

Copy link
Member

@pnkfelix pnkfelix commented Jan 2, 2020

triage: P-high. We may well revert PR #65244; see ongoing discussion in issue #67706

@pnkfelix pnkfelix added the P-high label Jan 2, 2020
@tmandry

This comment has been minimized.

Copy link
Contributor

@tmandry tmandry commented Jan 7, 2020

Fixed by #67768.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.