Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25% compile time increase on beta when building async-std #68864

Open
jonas-schievink opened this issue Feb 5, 2020 · 8 comments
Open

25% compile time increase on beta when building async-std #68864

jonas-schievink opened this issue Feb 5, 2020 · 8 comments

Comments

@jonas-schievink
Copy link
Member

@jonas-schievink jonas-schievink commented Feb 5, 2020

On my machine, cargo build on async-rs/async-std@1d87583 finishes in ~6.75s on stable 1.41.0, but takes at least 8.50s on the current beta (1.42.0-beta.2 (3d2613e 2020-02-04)), an increase of ~25%.

Recent nightlies are still affected, but my perf improvements in #68606 and #68672 improve things a bit which hides the regression.

@jonas-schievink

This comment has been minimized.

Copy link
Member Author

@jonas-schievink jonas-schievink commented Feb 5, 2020

nightly-2020-01-24

6.77s
6.74s

nightly-2020-01-25

8.38s
8.46s
@jonas-schievink

This comment has been minimized.

Copy link
Member Author

@jonas-schievink jonas-schievink commented Feb 5, 2020

Commits in that range: 41f41b2...c2d141d

@pnkfelix

This comment has been minimized.

Copy link
Member

@pnkfelix pnkfelix commented Feb 6, 2020

@jonas-schievink i figure until we've narrowed to a specific PR, we can keep the needs-bisect tag, right?

@pnkfelix

This comment has been minimized.

Copy link
Member

@pnkfelix pnkfelix commented Feb 6, 2020

triage: P-high. Assigning to self. might be good to see if we can extract a case to add to perf.rlo from this.

@pnkfelix pnkfelix self-assigned this Feb 6, 2020
@pnkfelix pnkfelix added the P-high label Feb 6, 2020
@michaelwoerister

This comment has been minimized.

Copy link
Contributor

@michaelwoerister michaelwoerister commented Feb 6, 2020

Is this for release or debug builds?

@jonas-schievink

This comment has been minimized.

Copy link
Member Author

@jonas-schievink jonas-schievink commented Feb 6, 2020

This is just a normal cargo build

@pnkfelix

This comment has been minimized.

Copy link
Member

@pnkfelix pnkfelix commented Feb 21, 2020

(I cannot reproduce the described regression in a reliable fashion on my Mac.)

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

@nikomatsakis nikomatsakis commented Feb 25, 2020

Maybe we can use self-profile to try and narrow down what has changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.