Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking no longer works after rust-lang/rust#68708 #68924

Open
ssomers opened this issue Feb 7, 2020 · 1 comment
Open

Benchmarking no longer works after rust-lang/rust#68708 #68924

ssomers opened this issue Feb 7, 2020 · 1 comment

Comments

@ssomers
Copy link
Contributor

@ssomers ssomers commented Feb 7, 2020

#68708 suspended the ability to benchmark liballoc (and probably others, but not everything). x.py bench (with or without --stage 0) now lists oodles of errors starting with:

Compiling getrandom v0.1.14
error: duplicate lang item in crate `core` (which `rustc_std_workspace_core` depends on): `bool`.
  |
  = note: first defined in crate `core` (which `getrandom` depends on)

It's still possible though to build and test benchmarks with say x.py test --stage 0 --no-doc.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Feb 7, 2020

Hm, it could be that some of those Lang items need to be cfg(not(test)) or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.