Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move keyword page makes no mention of async blocks #69298

Closed
That3Percent opened this issue Feb 19, 2020 · 2 comments · Fixed by #69477
Closed

Move keyword page makes no mention of async blocks #69298

That3Percent opened this issue Feb 19, 2020 · 2 comments · Fixed by #69477
Assignees
Labels
A-async-await A-docs AsyncAwait-Triaged C-enhancement E-mentor P-medium

Comments

@That3Percent
Copy link

That3Percent commented Feb 19, 2020

The move keyword page currently talks only about the use of move with closures. The move keyword is also valid before an async block. For example: async move { /*...*/ }. This page could be updated to include that usage.

This issue has been assigned to @Pulkit07 via this comment.

@jonas-schievink jonas-schievink added A-async-await C-enhancement A-docs labels Feb 19, 2020
@tmandry tmandry added AsyncAwait-Triaged P-medium E-needs-mentor labels Feb 25, 2020
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Feb 25, 2020

Mentoring instructions

Edit src/libstd/keyword_docs.rs and make the text talk about async blocks as well.

@nikomatsakis nikomatsakis added E-mentor and removed E-needs-mentor labels Feb 25, 2020
@Pulkit07
Copy link
Contributor

Pulkit07 commented Feb 25, 2020

@rustbot claim

@rustbot rustbot self-assigned this Feb 25, 2020
Pulkit07 added a commit to Pulkit07/rust that referenced this issue Feb 26, 2020
Pulkit07 added a commit to Pulkit07/rust that referenced this issue Feb 27, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Feb 29, 2020
docs: add mention of async blocks in move keyword docs

Fixes rust-lang#69298
@bors bors closed this as completed in 299a0d5 Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async-await A-docs AsyncAwait-Triaged C-enhancement E-mentor P-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants