Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't block further CI results on tidy/fmt #69613

Closed
CAD97 opened this issue Mar 1, 2020 · 1 comment
Closed

CI: don't block further CI results on tidy/fmt #69613

CAD97 opened this issue Mar 1, 2020 · 1 comment

Comments

@CAD97
Copy link
Contributor

@CAD97 CAD97 commented Mar 1, 2020

Some irlo context.

Currently, if a PR has even trivial tidy/fmt errors, the tidy/fmt error early-exits the PR smoke test CI and reports just the tidy/fmt error.

This can be problematic because of the long test cycle; it would reduce the number of required pushes/CI runs if CI could report both tidy/fmt nits alongside the test harness state.

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Mar 1, 2020

We can likely move tidy to the mingw-check builder and skip it on the longer builder.

Centril added a commit to Centril/rust that referenced this issue Mar 17, 2020
Move tidy check to mingw-check

Fixes rust-lang#69613
Centril added a commit to Centril/rust that referenced this issue Mar 17, 2020
Move tidy check to mingw-check

Fixes rust-lang#69613
@bors bors closed this in 91426e9 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.