Compare tagged/niche-filling layout and pick the best one #74069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
nikomatsakis
requested changes
Jul 16, 2020
|
☔ The latest upstream changes (presumably #74395) made this pull request unmergeable. Please resolve the merge conflicts. |
erikdesjardins
force-pushed
the
bad-niche
branch
from
c675d13
to
3924672
Compare
nikomatsakis
approved these changes
Jul 17, 2020
|
@bors r+ |
|
📌 Commit 3924672 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixes rust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 18, 2020
…sakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixes rust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
eddyb
approved these changes
Jul 18, 2020
|
Thanks a lot! I've closed my original unfinished PR. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2020
…arth Rollup of 11 pull requests Successful merges: - rust-lang#72414 ( Add lazy initialization primitives to std) - rust-lang#74069 (Compare tagged/niche-filling layout and pick the best one) - rust-lang#74418 (ci: Set `shell: bash` as a default, remove duplicates) - rust-lang#74441 (bootstrap.py: patch RPATH on NixOS to handle the new zlib dependency.) - rust-lang#74444 (Add regression test for rust-lang#69414) - rust-lang#74448 (improper_ctypes_definitions: allow `Box`) - rust-lang#74449 (Test codegen of compare_exchange operations) - rust-lang#74450 (Fix `Safety` docs for `from_raw_parts_mut`) - rust-lang#74453 (Use intra-doc links in `str` and `BTreeSet`) - rust-lang#74457 (rustbuild: drop tool::should_install) - rust-lang#74464 (Use pathdiff crate) Failed merges: r? @ghost
|
@rust-timer make-pr-for e775b4d |
rust-timer
added a commit
to rust-timer/rust
that referenced
this pull request
Jul 21, 2020
Original message: Rollup merge of rust-lang#74069 - erikdesjardins:bad-niche, r=nikomatsakis Compare tagged/niche-filling layout and pick the best one Finishes up rust-lang#71045, and so fixes rust-lang#63866. cc @eddyb r? @nikomatsakis (since @eddyb wrote the first commit)
|
Benchmarked in #74592, it does appear like this was a 5-10% performance regression on a large variety of crates. We should probably revert this PR. I've posted a revert here: xxx cc @nnethercote |
This was referenced Jul 22, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 23, 2020
…e, r=eddyb Revert "Compare tagged/niche-filling layout and pick the best one" Reverts rust-lang#74069. It caused a performance regression, see rust-lang#74069 (comment). perf: https://perf.rust-lang.org/compare.html?start=d3df8512d2c2afc6d2e7d8b5b951dd7f2ad77b02&end=cfade73820883adf654fe34fd6b0b03a99458a51 r? @eddyb cc @nnethercote
Closed
|
This turned out to not be the source of any regressions, and indeed might be a mild improvement. It will be re-landed in #74802. See also #74716 (comment) and the next few comments for discussion on this topic. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2020
…ercote Reland rust-lang#74069 Investigation in rust-lang#74716 has concluded that this PR is indeed not a regression (and in fact the rollup itself is not either). This reverts the revert in rust-lang#74611. r? @nnethercote cc @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes up #71045, and so fixes #63866.
cc @eddyb
r? @nikomatsakis (since @eddyb wrote the first commit)