Mingw 4.0 has broken headers #9246

Closed
vadimcn opened this Issue Sep 17, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@vadimcn
Contributor

vadimcn commented Sep 17, 2013

The latest mingw (4.0 as of this writing) has some broken headers, which break Rust build:

@klutzy

This comment has been minimized.

Show comment Hide comment
@klutzy

klutzy Sep 17, 2013

Contributor

cc #8598

Contributor

klutzy commented Sep 17, 2013

cc #8598

vadimcn added a commit to vadimcn/rust that referenced this issue Sep 17, 2013

The purpose of these headers is to fix issues with mingw v4.0, as des…
…cribed in #9246.

This works by adding this directory to GCC include search path before mingw system headers directories,
so we can intercept their inclusions and add missing definitions without having to modify files in mingw/include.

bors added a commit that referenced this issue Sep 18, 2013

auto merge of #9254 : vadimcn/rust/fix-mingw-v4, r=brson
Fix Rust build on mingw v4.0
See #9246 for details.
@klutzy

This comment has been minimized.

Show comment Hide comment
@klutzy

klutzy Nov 7, 2013

Contributor

FILE_FLAG_FIRST_PIPE_INSTANCE is fixed on mingw 4.0.3. Other two issues are still open.

Contributor

klutzy commented Nov 7, 2013

FILE_FLAG_FIRST_PIPE_INSTANCE is fixed on mingw 4.0.3. Other two issues are still open.

@alexcrichton

This comment has been minimized.

Show comment Hide comment
@alexcrichton

alexcrichton May 6, 2014

Owner

Have these all been fixed in moving to mingw-w64?

Owner

alexcrichton commented May 6, 2014

Have these all been fixed in moving to mingw-w64?

@klutzy

This comment has been minimized.

Show comment Hide comment
@klutzy

klutzy May 6, 2014

Contributor

Yep! (src/etc/mingw-fix-inlcude/ is still used, but it has no effect.)

Contributor

klutzy commented May 6, 2014

Yep! (src/etc/mingw-fix-inlcude/ is still used, but it has no effect.)

@vadimcn

This comment has been minimized.

Show comment Hide comment
@vadimcn

vadimcn May 6, 2014

Contributor

Are we ready to drop support for mingw? If so, we should get rid of
mingw-fix-include.

Contributor

vadimcn commented May 6, 2014

Are we ready to drop support for mingw? If so, we should get rid of
mingw-fix-include.

@alexcrichton

This comment has been minimized.

Show comment Hide comment
@alexcrichton

alexcrichton May 6, 2014

Owner

These aren't really much of a maintenance burden right now, so I don't think we need to invest too much effort into removing them.

I also wouldn't classify this as a bug any longer, however. If issues crop up in the future, we can remove the extra header files at that time, but for now we can say that we build on mingw but don't officially support it. Official support will be provided for mingw-w64.

Owner

alexcrichton commented May 6, 2014

These aren't really much of a maintenance burden right now, so I don't think we need to invest too much effort into removing them.

I also wouldn't classify this as a bug any longer, however. If issues crop up in the future, we can remove the extra header files at that time, but for now we can say that we build on mingw but don't officially support it. Official support will be provided for mingw-w64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment