Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constify slice flatten method #111127

Merged
merged 1 commit into from May 4, 2023
Merged

Constify slice flatten method #111127

merged 1 commit into from May 4, 2023

Conversation

KamilaBorowska
Copy link
Contributor

@KamilaBorowska KamilaBorowska commented May 3, 2023 •
edited

@rustbot
Copy link
Collaborator

rustbot commented May 3, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 3, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@KamilaBorowska
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 3, 2023
@scottmcm
Copy link
Member

scottmcm commented May 3, 2023

Looks good to me!

r? @scottmcm
@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented May 3, 2023

📌 Commit 4fec8a3 has been approved by scottmcm

It is now in the queue for this repository.

@rustbot rustbot assigned scottmcm and unassigned joshtriplett May 3, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2023
@scottmcm
Copy link
Member

scottmcm commented May 3, 2023

Hmm, should flatten_mut also get const?

Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111127 - xfix:const-slice-flatten, r=scottmcm
1b255c8 
Constify slice flatten method

ACP: rust-lang/libs-team#218
@Manishearth Manishearth mentioned this pull request May 3, 2023
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111127 - xfix:const-slice-flatten, r=scottmcm
cfa16c8 
Constify slice flatten method

ACP: rust-lang/libs-team#218
This was referenced May 3, 2023
Closed
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111127 - xfix:const-slice-flatten, r=scottmcm
2986ec1 
Constify slice flatten method

ACP: rust-lang/libs-team#218
@Manishearth Manishearth mentioned this pull request May 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2023
@bors
Auto merge of rust-lang#111169 - Manishearth:rollup-55sfaad, r=Manish…
129195f 
…earth

Rollup of 10 pull requests

Successful merges:

 - rust-lang#97594 (Implement tuple<->array convertions via `From`)
 - rust-lang#105452 (Add cross-language LLVM CFI support to the Rust compiler)
 - rust-lang#105695 (Replace generic thread parker with explicit no-op parker)
 - rust-lang#110371 (rustdoc: restructure type search engine to pick-and-use IDs)
 - rust-lang#110928 (tests: Add tests for LoongArch64)
 - rust-lang#110970 (tidy: remove ENTRY_LIMIT maximum checking and set it to 900)
 - rust-lang#111104 (Update ICU4X to 1.2)
 - rust-lang#111127 (Constify slice flatten method)
 - rust-lang#111146 (rustc_middle: Fix `opt_item_ident` for non-local def ids)
 - rust-lang#111154 (Use builtin FFX isolation for Fuchsia test runner)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54cf561 into rust-lang:master May 4, 2023
11 checks passed
@rustbot rustbot added this to the 1.71.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@KamilaBorowska @rustbot @scottmcm @bors @joshtriplett