-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct llvm-profdata
binary in opt-dist
#114344
Conversation
Use the correct `llvm-profdata` binary in `opt-dist`
0a83fd8
to
acb617c
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit acb617c with merge 5e93bd21fa944a163ae2b92f058b2ea8f4622840... |
☀️ Try build successful - checks-actions |
@rust-timer build 5e93bd21fa944a163ae2b92f058b2ea8f4622840 |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (5e93bd21fa944a163ae2b92f058b2ea8f4622840): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.605s -> 647.928s (-0.41%) |
@bors r+ |
⌛ Testing commit acb617c with merge 723895ee45f5edbdb3c350bb49db602ad627a467... |
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
@bors retry |
@bors retry |
@bors r=nikic |
💡 This pull request was already approved, no need to approve it again.
|
I know, bors, I know. |
Finished benchmarking commit (723895ee45f5edbdb3c350bb49db602ad627a467): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 652.069s -> 650.598s (-0.23%) |
☀️ Test successful - checks-actions |
Rename method in `opt-dist` This makes it clearer that the LLVM is the host one (it doesn't necessarily have to be downloaded). On Linux, it comes from the Dockerfile, on Windows it's downloaded. Suggested here: rust-lang#114344 (comment) r? `@lqd`
Finished benchmarking commit (03a119b): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 651.258s -> 652.752s (0.23%) |
Turns out that we were probably using the wrong
llvm-profdata
binary in the PGO script all along. This should resolve the performance regressions of switching the host LLVM to 17 (hostllvm-profdata
, targetllvm-profdata
]).r? @nikic