Skip to content

/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rust to build with LLVM 3.3/3.4 #12581

Merged
merged 2 commits into from Feb 27, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alexcrichton @flaper87 @bors @brson
@alexcrichton
Copy link
Member

alexcrichton commented Feb 26, 2014

In doing so, revert travis to not using a 3.5 build because it seems to be changing enough that it's breaking our C++ glue frequently enough.

alexcrichton added some commits Feb 26, 2014

@alexcrichton
rustc: Get rustc compiling with LLVM 3.{3,4} again 
The travis builds have been breaking recently because LLVM 3.5 upstream is
changing. This looks like it's likely to continue, so it would be more useful
for us if we could lock ourselves to a system LLVM version that is not changing.

This commit has the support to bring our C++ glue to LLVM back in line with what
was possible back in LLVM 3.{3,4}. I don't think we're going to be able to
reasonably protect against regressions in the future, but this kind of code is a
good sign that we can continue to use the system LLVM for simple-ish things.
Codegen for ARM won't work and it won't have some of the perf improvements we
have, but using the system LLVM should work well enough for development.
1ac5e84
@alexcrichton
travis: Use LLVM 3.3 from the official repos 
We can be certain that this version of LLVM will not be changing, so we don't
have to worry about API drift over time.
Loading status checks…
bbdaf01
@flaper87

This comment has been minimized.

Sign in to view
Copy link
Contributor

flaper87 commented Feb 26, 2014

LGTM 🍰 👍
@brson

This comment has been minimized.

Sign in to view
Copy link

brson commented on bbdaf01 Feb 27, 2014

r+ p=1
@bors

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors commented on bbdaf01 Feb 27, 2014

saw approval from brson
at alexcrichton@bbdaf01

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Feb 27, 2014

merging alexcrichton/rust/older-llvm = bbdaf01 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Feb 27, 2014

alexcrichton/rust/older-llvm = bbdaf01 merged ok, testing candidate = 68a92c5

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Feb 27, 2014

all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4499
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/2341
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/2342
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4497
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/3597
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3603
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4512
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/3600
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/3606
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4514
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/3600
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/3605
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/3674
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1453
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4506
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/3607
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3613
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4273

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors replied Feb 27, 2014

fast-forwarding master to auto = 68a92c5

bors added a commit that referenced this pull request Feb 27, 2014

@bors
auto merge of #12581 : alexcrichton/rust/older-llvm, r=brson 
In doing so, revert travis to not using a 3.5 build because it seems to be changing enough that it's breaking our C++ glue frequently enough.
68a92c5

@bors bors closed this Feb 27, 2014

@bors bors merged commit bbdaf01 into rust-lang:master Feb 27, 2014
1 check passed

1 check passed

default all tests passed

@alexcrichton alexcrichton deleted the alexcrichton:older-llvm branch Feb 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.