native: Skip non-utf16 filename on Windows

[klutzy]

This fixes glob::test::test_lots_of_files test on my machine:
it entered C:\$Recycle.Bin\ and there were some system files with
non-utf16 names.

[kballard]

Can you give me an example of one of the names? I have a long-standing issue on my plate to reinvestigate filepaths on Windows due to rumors of non-utf16 names, but I don't have any concrete data on this.

Was it some sort of UCS2 name that's invalid UTF-16, or does Windows genuinely let you have names that aren't Unicode at all?

[kballard]

Can you give me an example of one of the names? I have a long-standing issue on my plate to reinvestigate filepaths on Windows due to rumors of non-utf16 names, but I don't have any concrete data on this.

Was it some sort of UCS2 name that's invalid UTF-16, or does Windows genuinely let you have names that aren't Unicode at all?

[klutzy]

I (on win8) succeeded to create files with strange names: [0xd800, 0xdc00] (\U00010000), [0xdc00] (surrogate only) and [0xdc73, 0xdc79] (two low surrogates). The last example is even from system file of recycle bin.

[klutzy]

I (on win8) succeeded to create files with strange names: [0xd800, 0xdc00] (\U00010000), [0xdc00] (surrogate only) and [0xdc73, 0xdc79] (two low surrogates). The last example is even from system file of recycle bin.

[kballard]

@klutzy Ok thanks, that sounds like it's still valid UCS2, just not UTF-16. So it's not a big surprise.

Still, it is a reason why WindowsPath may need to move to using [u8] internally instead of str, which is unfortunate.

[kballard]

@klutzy Ok thanks, that sounds like it's still valid UCS2, just not UTF-16. So it's not a big surprise.

Still, it is a reason why WindowsPath may need to move to using [u8] internally instead of str, which is unfortunate.

[alexcrichton]

Interesting! I would also like to add a test for this to ensure that this doesn't crop up again. I'm also a little worried how librustuv handles this case.

I don't think that from rust you can easily create a non-utf16 filename, but you should be able to add a run-make test with a file already in the directory.

[alexcrichton]

Interesting! I would also like to add a test for this to ensure that this doesn't crop up again. I'm also a little worried how librustuv handles this case.

I don't think that from rust you can easily create a non-utf16 filename, but you should be able to add a run-make test with a file already in the directory.

[alexcrichton]

Closing due to inactivity, but feel free to reopen with a rebase!

[alexcrichton]

Closing due to inactivity, but feel free to reopen with a rebase!