Skip to content

Conversation

@compiler-errors
Copy link
Member

Collect higher-ranked coroutines outlives, even if we don't use them, for perf.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 19, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 19, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 19, 2025
[PERF] Collect higher-ranked coroutines outlives assumptions

Collect higher-ranked coroutines outlives, even if we don't use them, for perf.
@bors
Copy link
Collaborator

bors commented May 19, 2025

⌛ Trying commit 2cd05fd with merge ff8a8f7...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
region variables should not be hashed: '?0
stack backtrace:
   0:     0x7ff777f69d30 - <<std[a247767d155a25aa]::sys::backtrace::BacktraceLock>::print::DisplayBacktrace as core[31bbb435895bef97]::fmt::Display>::fmt
   1:     0x7ff777fc8bcf - core[31bbb435895bef97]::fmt::write
   2:     0x7ff777f5cdf9 - <std[a247767d155a25aa]::sys::stdio::unix::Stderr as std[a247767d155a25aa]::io::Write>::write_fmt
   3:     0x7ff777f69bd2 - <std[a247767d155a25aa]::sys::backtrace::BacktraceLock>::print
   4:     0x7ff777f6e3d8 - std[a247767d155a25aa]::panicking::default_hook::{closure#0}
   5:     0x7ff777f6e172 - std[a247767d155a25aa]::panicking::default_hook
   6:     0x7ff7733ae374 - std[a247767d155a25aa]::panicking::update_hook::<alloc[3dc6c0d286180b4]::boxed::Box<rustc_driver_impl[ef692c2598d9a202]::install_ice_hook::{closure#1}>>::{closure#0}
   7:     0x7ff777f6f053 - std[a247767d155a25aa]::panicking::rust_panic_with_hook
   8:     0x7ff777f6ec4e - std[a247767d155a25aa]::panicking::begin_panic_handler::{closure#0}
   9:     0x7ff777f6a349 - std[a247767d155a25aa]::sys::backtrace::__rust_end_short_backtrace::<std[a247767d155a25aa]::panicking::begin_panic_handler::{closure#0}, !>
  10:     0x7ff777f6e85d - __rustc[1ac6cdfe3ab8fc00]::rust_begin_unwind
  11:     0x7ff777fc39e0 - core[31bbb435895bef97]::panicking::panic_fmt
  12:     0x7ff777886c7a - <rustc_middle[f9407c3a15458d61]::ty::region::Region as rustc_data_structures[aecab0403765e638]::stable_hasher::HashStable<rustc_query_system[fb9bff0c36cd732e]::ich::hcx::StableHashingContext>>::hash_stable
  13:     0x7ff777886166 - <rustc_middle[f9407c3a15458d61]::ty::generic_args::GenericArg as rustc_data_structures[aecab0403765e638]::stable_hasher::HashStable<rustc_query_system[fb9bff0c36cd732e]::ich::hcx::StableHashingContext>>::hash_stable
  14:     0x7ff776343ff0 - <[rustc_type_ir[172b2f4ae0ad0f8b]::predicate::OutlivesPredicate<rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt, rustc_middle[f9407c3a15458d61]::ty::generic_args::GenericArg>] as rustc_data_structures[aecab0403765e638]::stable_hasher::HashStable<rustc_query_system[fb9bff0c36cd732e]::ich::hcx::StableHashingContext>>::hash_stable
  15:     0x7ff77617fc7d - <std[a247767d155a25aa]::thread::local::LocalKey<core[31bbb435895bef97]::cell::RefCell<std[a247767d155a25aa]::collections::hash::map::HashMap<(*const (), rustc_data_structures[aecab0403765e638]::stable_hasher::HashingControls), rustc_data_structures[aecab0403765e638]::fingerprint::Fingerprint, rustc_hash[6e3bc34dc1c40ede]::FxBuildHasher>>>>::with::<<&rustc_middle[f9407c3a15458d61]::ty::list::RawList<(), rustc_type_ir[172b2f4ae0ad0f8b]::predicate::OutlivesPredicate<rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt, rustc_middle[f9407c3a15458d61]::ty::generic_args::GenericArg>> as rustc_data_structures[aecab0403765e638]::stable_hasher::HashStable<rustc_query_system[fb9bff0c36cd732e]::ich::hcx::StableHashingContext>>::hash_stable::{closure#0}, rustc_data_structures[aecab0403765e638]::fingerprint::Fingerprint>
  16:     0x7ff7764ca60d - <&rustc_middle[f9407c3a15458d61]::ty::list::RawList<(), rustc_type_ir[172b2f4ae0ad0f8b]::predicate::OutlivesPredicate<rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt, rustc_middle[f9407c3a15458d61]::ty::generic_args::GenericArg>> as rustc_data_structures[aecab0403765e638]::stable_hasher::HashStable<rustc_query_system[fb9bff0c36cd732e]::ich::hcx::StableHashingContext>>::hash_stable
  17:     0x7ff776105a08 - <rustc_query_impl[9a712e6ab382338e]::query_impl::coroutine_hidden_types::dynamic_query::{closure#7} as core[31bbb435895bef97]::ops::function::FnOnce<(&mut rustc_query_system[fb9bff0c36cd732e]::ich::hcx::StableHashingContext, &rustc_middle[f9407c3a15458d61]::query::erase::Erased<[u8; 24usize]>)>>::call_once
  18:     0x7ff775fdfa2f - rustc_query_system[fb9bff0c36cd732e]::query::plumbing::try_execute_query::<rustc_query_impl[9a712e6ab382338e]::DynamicConfig<rustc_query_system[fb9bff0c36cd732e]::query::caches::DefIdCache<rustc_middle[f9407c3a15458d61]::query::erase::Erased<[u8; 24usize]>>, false, false, false>, rustc_query_impl[9a712e6ab382338e]::plumbing::QueryCtxt, false>
  19:     0x7ff77638571b - rustc_query_impl[9a712e6ab382338e]::query_impl::coroutine_hidden_types::get_query_non_incr::__rust_end_short_backtrace
  20:     0x7ff776a8f82b - rustc_trait_selection[167d39720f1643d6]::traits::select::rebind_coroutine_witness_types
  21:     0x7ff776aac4ce - <rustc_trait_selection[167d39720f1643d6]::traits::select::SelectionContext>::constituent_types_for_ty
  22:     0x7ff776a96e5d - <rustc_trait_selection[167d39720f1643d6]::traits::select::SelectionContext>::confirm_candidate
  23:     0x7ff776aa256b - <rustc_trait_selection[167d39720f1643d6]::traits::select::SelectionContext>::poly_select
  24:     0x7ff7769ccc06 - <rustc_trait_selection[167d39720f1643d6]::traits::fulfill::FulfillProcessor>::process_trait_obligation
  25:     0x7ff7769caf67 - <rustc_trait_selection[167d39720f1643d6]::traits::fulfill::FulfillProcessor as rustc_data_structures[aecab0403765e638]::obligation_forest::ObligationProcessor>::process_obligation
  26:     0x7ff7769879cf - <rustc_data_structures[aecab0403765e638]::obligation_forest::ObligationForest<rustc_trait_selection[167d39720f1643d6]::traits::fulfill::PendingPredicateObligation>>::process_obligations::<rustc_trait_selection[167d39720f1643d6]::traits::fulfill::FulfillProcessor>
  27:     0x7ff773f2bfc0 - <rustc_trait_selection[167d39720f1643d6]::traits::fulfill::FulfillmentContext<rustc_trait_selection[167d39720f1643d6]::traits::FulfillmentError> as rustc_infer[86f89b0bb35d1026]::traits::engine::TraitEngine<rustc_trait_selection[167d39720f1643d6]::traits::FulfillmentError>>::select_where_possible
  28:     0x7ff773bdf861 - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_argument_types
  29:     0x7ff773ba0072 - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::confirm_builtin_call
  30:     0x7ff773c67f65 - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_expr_kind
  31:     0x7ff773bb667d - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
  32:     0x7ff773c62396 - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_expr_with_expectation
  33:     0x7ff773beccdb - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_expr_block
  34:     0x7ff773c64747 - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_expr_kind
  35:     0x7ff773bb667d - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_expr_with_expectation_and_args
  36:     0x7ff773c62396 - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_expr_with_expectation
  37:     0x7ff773bb7efb - <rustc_hir_typeck[e3d2b4eacefeb097]::fn_ctxt::FnCtxt>::check_return_or_body_tail
  38:     0x7ff773f4823a - rustc_hir_typeck[e3d2b4eacefeb097]::check::check_fn
  39:     0x7ff773f5750b - rustc_hir_typeck[e3d2b4eacefeb097]::typeck_with_inspect
  40:     0x7ff776201015 - rustc_query_impl[9a712e6ab382338e]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[9a712e6ab382338e]::query_impl::typeck::dynamic_query::{closure#2}::{closure#0}, rustc_middle[f9407c3a15458d61]::query::erase::Erased<[u8; 8usize]>>
  41:     0x7ff776127d65 - <rustc_query_impl[9a712e6ab382338e]::query_impl::typeck::dynamic_query::{closure#2} as core[31bbb435895bef97]::ops::function::FnOnce<(rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt, rustc_span[e1beaf19d1e530bc]::def_id::LocalDefId)>>::call_once
  42:     0x7ff77606fc1c - rustc_query_system[fb9bff0c36cd732e]::query::plumbing::try_execute_query::<rustc_query_impl[9a712e6ab382338e]::DynamicConfig<rustc_data_structures[aecab0403765e638]::vec_cache::VecCache<rustc_span[e1beaf19d1e530bc]::def_id::LocalDefId, rustc_middle[f9407c3a15458d61]::query::erase::Erased<[u8; 8usize]>, rustc_query_system[fb9bff0c36cd732e]::dep_graph::graph::DepNodeIndex>, false, false, false>, rustc_query_impl[9a712e6ab382338e]::plumbing::QueryCtxt, false>
  43:     0x7ff776438d86 - rustc_query_impl[9a712e6ab382338e]::query_impl::typeck::get_query_non_incr::__rust_end_short_backtrace
  44:     0x7ff7740fdb41 - <rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt>::par_hir_body_owners::<rustc_hir_analysis[6caae9b100173e1c]::check_crate::{closure#1}>::{closure#0}
  45:     0x7ff7740e98ca - rustc_data_structures[aecab0403765e638]::sync::parallel::par_for_each_in::<&rustc_span[e1beaf19d1e530bc]::def_id::LocalDefId, &[rustc_span[e1beaf19d1e530bc]::def_id::LocalDefId], <rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt>::par_hir_body_owners<rustc_hir_analysis[6caae9b100173e1c]::check_crate::{closure#1}>::{closure#0}>
  46:     0x7ff7743cd344 - rustc_hir_analysis[6caae9b100173e1c]::check_crate
  47:     0x7ff77387c432 - rustc_interface[c4327e0b5b2e2b9]::passes::analysis
  48:     0x7ff776201663 - rustc_query_impl[9a712e6ab382338e]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[9a712e6ab382338e]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[f9407c3a15458d61]::query::erase::Erased<[u8; 0usize]>>
  49:     0x7ff776128de1 - <rustc_query_impl[9a712e6ab382338e]::query_impl::analysis::dynamic_query::{closure#2} as core[31bbb435895bef97]::ops::function::FnOnce<(rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt, ())>>::call_once
  50:     0x7ff775fee7f9 - rustc_query_system[fb9bff0c36cd732e]::query::plumbing::try_execute_query::<rustc_query_impl[9a712e6ab382338e]::DynamicConfig<rustc_query_system[fb9bff0c36cd732e]::query::caches::SingleCache<rustc_middle[f9407c3a15458d61]::query::erase::Erased<[u8; 0usize]>>, false, false, false>, rustc_query_impl[9a712e6ab382338e]::plumbing::QueryCtxt, false>
  51:     0x7ff7764eb722 - rustc_query_impl[9a712e6ab382338e]::query_impl::analysis::get_query_non_incr::__rust_end_short_backtrace
  52:     0x7ff7733c8294 - <std[a247767d155a25aa]::thread::local::LocalKey<core[31bbb435895bef97]::cell::Cell<*const ()>>>::with::<rustc_middle[f9407c3a15458d61]::ty::context::tls::enter_context<<rustc_middle[f9407c3a15458d61]::ty::context::GlobalCtxt>::enter<rustc_interface[c4327e0b5b2e2b9]::passes::create_and_enter_global_ctxt<core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>, rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}, core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>>::{closure#1}, core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>>::{closure#0}, core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>>
  53:     0x7ff77348a6e2 - <rustc_middle[f9407c3a15458d61]::ty::context::TyCtxt>::create_global_ctxt::<core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>, rustc_interface[c4327e0b5b2e2b9]::passes::create_and_enter_global_ctxt<core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>, rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0}>
  54:     0x7ff773430236 - <rustc_interface[c4327e0b5b2e2b9]::passes::create_and_enter_global_ctxt<core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>, rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}::{closure#2}>::{closure#2} as core[31bbb435895bef97]::ops::function::FnOnce<(&rustc_session[4c99ea86608ac7ac]::session::Session, rustc_middle[f9407c3a15458d61]::ty::context::CurrentGcx, alloc[3dc6c0d286180b4]::sync::Arc<rustc_data_structures[aecab0403765e638]::jobserver::Proxy>, &std[a247767d155a25aa]::sync::once_lock::OnceLock<rustc_middle[f9407c3a15458d61]::ty::context::GlobalCtxt>, &rustc_data_structures[aecab0403765e638]::sync::worker_local::WorkerLocal<rustc_middle[f9407c3a15458d61]::arena::Arena>, &rustc_data_structures[aecab0403765e638]::sync::worker_local::WorkerLocal<rustc_hir[88d70bbc8b1d8677]::Arena>, rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}::{closure#2})>>::call_once::{shim:vtable#0}
  55:     0x7ff7733b6fb6 - <alloc[3dc6c0d286180b4]::boxed::Box<dyn for<'a> core[31bbb435895bef97]::ops::function::FnOnce<(&'a rustc_session[4c99ea86608ac7ac]::session::Session, rustc_middle[f9407c3a15458d61]::ty::context::CurrentGcx, alloc[3dc6c0d286180b4]::sync::Arc<rustc_data_structures[aecab0403765e638]::jobserver::Proxy>, &'a std[a247767d155a25aa]::sync::once_lock::OnceLock<rustc_middle[f9407c3a15458d61]::ty::context::GlobalCtxt<'a>>, &'a rustc_data_structures[aecab0403765e638]::sync::worker_local::WorkerLocal<rustc_middle[f9407c3a15458d61]::arena::Arena<'a>>, &'a rustc_data_structures[aecab0403765e638]::sync::worker_local::WorkerLocal<rustc_hir[88d70bbc8b1d8677]::Arena<'a>>, rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}::{closure#2}), Output = core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>>> as core[31bbb435895bef97]::ops::function::FnOnce<(&rustc_session[4c99ea86608ac7ac]::session::Session, rustc_middle[f9407c3a15458d61]::ty::context::CurrentGcx, alloc[3dc6c0d286180b4]::sync::Arc<rustc_data_structures[aecab0403765e638]::jobserver::Proxy>, &std[a247767d155a25aa]::sync::once_lock::OnceLock<rustc_middle[f9407c3a15458d61]::ty::context::GlobalCtxt>, &rustc_data_structures[aecab0403765e638]::sync::worker_local::WorkerLocal<rustc_middle[f9407c3a15458d61]::arena::Arena>, &rustc_data_structures[aecab0403765e638]::sync::worker_local::WorkerLocal<rustc_hir[88d70bbc8b1d8677]::Arena>, rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}::{closure#2})>>::call_once
  56:     0x7ff77340daf7 - rustc_interface[c4327e0b5b2e2b9]::passes::create_and_enter_global_ctxt::<core[31bbb435895bef97]::option::Option<rustc_interface[c4327e0b5b2e2b9]::queries::Linker>, rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}::{closure#2}>
  57:     0x7ff77344cbc9 - rustc_span[e1beaf19d1e530bc]::create_session_globals_then::<(), rustc_interface[c4327e0b5b2e2b9]::util::run_in_thread_with_globals<rustc_interface[c4327e0b5b2e2b9]::util::run_in_thread_pool_with_globals<rustc_interface[c4327e0b5b2e2b9]::interface::run_compiler<(), rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}::{closure#0}>
  58:     0x7ff7733e55e9 - std[a247767d155a25aa]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[c4327e0b5b2e2b9]::util::run_in_thread_with_globals<rustc_interface[c4327e0b5b2e2b9]::util::run_in_thread_pool_with_globals<rustc_interface[c4327e0b5b2e2b9]::interface::run_compiler<(), rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>
  59:     0x7ff7733e8394 - <<std[a247767d155a25aa]::thread::Builder>::spawn_unchecked_<rustc_interface[c4327e0b5b2e2b9]::util::run_in_thread_with_globals<rustc_interface[c4327e0b5b2e2b9]::util::run_in_thread_pool_with_globals<rustc_interface[c4327e0b5b2e2b9]::interface::run_compiler<(), rustc_driver_impl[ef692c2598d9a202]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[31bbb435895bef97]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
  60:     0x7ff777f74512 - <std[a247767d155a25aa]::sys::pal::unix::thread::Thread>::new::thread_start
---
note: please make sure that you have updated to the latest nightly

note: please attach the file at `/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.8/rustc-ice-2025-05-19T12_06_15-33886.txt` to your bug report

note: compiler flags: --crate-type lib -C opt-level=3 -C embed-bitcode=no -C debug-assertions=on -C symbol-mangling-version=v0 -Z unstable-options -Z macro-backtrace -C split-debuginfo=off -C link-arg=-L/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/lib -C link-args=-Wl,-z,origin -C link-args=-Wl,-rpath,$ORIGIN/../lib -Z unstable-options -Z binary-dep-depinfo -Z on-broken-pipe=kill -Z tls-model=initial-exec

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
#0 [typeck] type-checking `client::legacy::client::<impl at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.8/src/client/legacy/client.rs:140:1: 145:53>::request`
#1 [analysis] running analysis passes on this crate
end of query stack
[RUSTC-TIMING] hyper test:false 2.781
   Compiling scraper v0.20.0
[RUSTC-TIMING] hyper_util test:false 1.513
error: could not compile `hyper-util` (lib)

Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc /checkout/obj/build/bootstrap/debug/rustc --crate-name hyper_util --edition=2021 /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.8/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C debug-assertions=on --cfg 'feature="client"' --cfg 'feature="client-legacy"' --cfg 'feature="default"' --cfg 'feature="http1"' --cfg 'feature="tokio"' --check-cfg 'cfg(docsrs,test)' --check-cfg 'cfg(feature, values("__internal_happy_eyeballs_tests", "client", "client-legacy", "default", "full", "http1", "http2", "server", "server-auto", "server-graceful", "service", "tokio"))' -C metadata=06bce69d39cf1852 -C extra-filename=-dea81637fe99764d --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps --extern bytes=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libbytes-9f92c9f459464ad0.rmeta --extern futures_channel=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures_channel-9a32e9e75b1a0672.rmeta --extern futures_util=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libfutures_util-a4acc823800301a2.rmeta --extern http=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libhttp-f4dce6fa494dec7c.rmeta --extern http_body=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libhttp_body-d0fde02f0d7bf4c0.rmeta --extern hyper=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libhyper-6e7ef49f23a537a9.rmeta --extern pin_project_lite=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libpin_project_lite-15adad65b151188c.rmeta --extern socket2=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libsocket2-618d0063acde61de.rmeta --extern tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtokio-51884dcebab597d3.rmeta --extern tower=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtower-ce5a75e5050de5b2.rmeta --extern tower_service=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtower_service-3faacd863458c5c9.rmeta --extern tracing=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/deps/libtracing-c06098a1527e7231.rmeta --cap-lints allow --cfg=windows_raw_dylib -Csymbol-mangling-version=v0 -Zunstable-options '--check-cfg=cfg(bootstrap)' '--check-cfg=cfg(llvm_enzyme)' '--check-cfg=cfg(rust_analyzer)' -Zmacro-backtrace -Csplit-debuginfo=off -Clink-arg=-L/checkout/obj/build/x86_64-unknown-linux-gnu/ci-llvm/lib -Clink-args=-Wl,-z,origin '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Alinker-messages -Zunstable-options -Z binary-dep-depinfo` (exit status: 101)
warning: build failed, waiting for other jobs to finish...
[RUSTC-TIMING] html5ever test:false 2.757
[RUSTC-TIMING] selectors test:false 3.251
[RUSTC-TIMING] rustls test:false 10.788
[RUSTC-TIMING] scraper test:false 2.914
---
    Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
[TIMING] core::build_steps::tool::LibcxxVersionTool { target: x86_64-unknown-linux-gnu } -- 0.001
ERROR: Tool `book` was not recorded in tool state.
ERROR: Tool `nomicon` was not recorded in tool state.
ERROR: Tool `reference` was not recorded in tool state.
ERROR: Tool `rust-by-example` was not recorded in tool state.
ERROR: Tool `edition-guide` was not recorded in tool state.
ERROR: Tool `embedded-book` was not recorded in tool state.
Build completed unsuccessfully in 0:00:00
  local time: Mon May 19 12:06:19 UTC 2025
  network time: Mon, 19 May 2025 12:06:19 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@bors
Copy link
Collaborator

bors commented May 19, 2025

☀️ Try build successful - checks-actions
Build commit: ff8a8f7 (ff8a8f787945f6abafb4b441c14b5bd559eb648c)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ff8a8f7): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
1.1% [1.1%, 1.1%] 1
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.1% [1.1%, 1.1%] 1

Max RSS (memory usage)

Results (primary -3.7%, secondary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.9% [2.4%, 3.3%] 2
Improvements ✅
(primary)
-3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)
-1.8% [-3.6%, -0.5%] 7
All ❌✅ (primary) -3.7% [-3.7%, -3.7%] 1

Cycles

Results (secondary -1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.0% [-1.4%, -0.6%] 7
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.359s -> 776.703s (0.17%)
Artifact size: 365.57 MiB -> 365.41 MiB (-0.04%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants