From d66647ba2c73c353461ceb34f2501496f1576aa1 Mon Sep 17 00:00:00 2001 From: Noratrieb <48135649+Noratrieb@users.noreply.github.com> Date: Fri, 17 Oct 2025 23:28:54 +0200 Subject: [PATCH] Reword unstable finterprint ICE to ask for reproduction When the unstable finterprint error was added, Rust was on fire, and we needed a quick way for people to sort of understand what's going on, follow the tracking issue, and leave some information without overwhelming the issue tracker and focusing on getting their code working. This is what motivated the previous message. It called this a "known issue", provided help on how to fix it, and only secondarily asked for a bug report. This is no longer true. These days incremental compilation is fairly solid and these issues are supposed to be rare, we expect *none* of them to exist (but obviously know that's not true). As such, it's time to reword this message. Recently someone mentioned how they didn't bother reporting this issue because it said that it was a "known issue", and I only got awareness of their problem because they complained about all the rustc-ice files hanging around their directories. This is not at all what we want, we want reports from people, ideally with a reproduction. To get this, I reworded the error. It now explicitly asks for a reproduction (and explaining what that means) and no longer calls it a "known issue". It also does not link to the tracking issue anymore, because I don't think this tracking issue is useful. It should probably be closed. I still mention the workaround, but explicitly call it a "workaround". People should report a reproduction and only *then* use the workaround. --- compiler/rustc_query_system/messages.ftl | 5 +++-- compiler/rustc_query_system/src/error.rs | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/compiler/rustc_query_system/messages.ftl b/compiler/rustc_query_system/messages.ftl index f686608034cba..d2ab2d34c5fcc 100644 --- a/compiler/rustc_query_system/messages.ftl +++ b/compiler/rustc_query_system/messages.ftl @@ -16,10 +16,11 @@ query_system_cycle_stack_single = ...which immediately requires {$stack_bottom} query_system_cycle_usage = cycle used when {$usage} query_system_increment_compilation = internal compiler error: encountered incremental compilation error with {$dep_node} - .help = This is a known issue with the compiler. Run {$run_cmd} to allow your project to compile query_system_increment_compilation_note1 = please follow the instructions below to create a bug report with the provided information -query_system_increment_compilation_note2 = see for more information +query_system_increment_compilation_note2 = for incremental compilation bugs, having a reproduction is vital +query_system_increment_compilation_note3 = an ideal reproduction consists of the code before and some patch that then triggers the bug when applied and compiled again +query_system_increment_compilation_note4 = as a workaround, you can run {$run_cmd} to allow your project to compile query_system_overflow_note = query depth increased by {$depth} when {$desc} diff --git a/compiler/rustc_query_system/src/error.rs b/compiler/rustc_query_system/src/error.rs index 2778b24e7741b..96998c7986897 100644 --- a/compiler/rustc_query_system/src/error.rs +++ b/compiler/rustc_query_system/src/error.rs @@ -69,9 +69,10 @@ pub(crate) struct Reentrant; #[derive(Diagnostic)] #[diag(query_system_increment_compilation)] -#[help] #[note(query_system_increment_compilation_note1)] #[note(query_system_increment_compilation_note2)] +#[note(query_system_increment_compilation_note3)] +#[note(query_system_increment_compilation_note4)] pub(crate) struct IncrementCompilation { pub run_cmd: String, pub dep_node: String,