Implement Read::read_array
#148850
Open
Implement Read::read_array
#148850
+40
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking issue: rust-lang#148848
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
4 tasks
Comment on lines
+1280
to
+1281
| self.read_buf_exact(borrowed_buf.unfilled())?; | ||
| Ok(unsafe { MaybeUninit::array_assume_init(buf) }) |
Contributor
There was a problem hiding this comment.
I'm pretty sure this is unsound if read_buf_exact is implemented incorrectly by safe code (return Ok(()) without having written the whole buffer).
Contributor
There was a problem hiding this comment.
Yes, there should be a check for borrowed_buf.len() == N. After than the array_assume_init would be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #148848