rustc_hir_analysis: Remove premature classification of repeats as AnonConstKind::MCG
#148852
+17
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148822
Tracking issue: #132980
Root cause:
rust/compiler/rustc_hir_analysis/src/collect.rs
Lines 1840 to 1851 in 996a185
L1840 causes const args to be identified prematurely when the feature is enabled. for repeat array this is problematic because the next else-if at 1842 will not be hit (but it should be).
Fix:
Removed L1840 else-if block, it seems redundant if we move below the L1842 one, but it might have other responsibilities later on?
Testing:
Regression test from the issue.
r? @BoxyUwU