-
Notifications
You must be signed in to change notification settings - Fork 14k
Remove context dependant ! fallback
#148871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WaffleLapkin
wants to merge
8
commits into
rust-lang:main
Choose a base branch
from
WaffleLapkin:never-simplifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code supporting it is extremely confusing. At the same time, we have no plans to use this scheme, so there is no value in supporting it.
the only diagnostic that was using this field specifically сares for the never type fallback, not the integer fallback.
I think in this case the early return is harder to read than just an if. "if fallback hasn't occured we don't do..."
this is about context dependant case which I removed a few commits back
... now that it's always the same for a certain crate
This comment has been minimized.
This comment has been minimized.
Member
Author
|
I have really low confidence in the never type tests, IMO they require a major refactoring, as a lot of them are based on outdated ideas and features... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
For the tests, I would expect us to have revisions for edition 2021 and edition 2024 (for the different fallbacks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
F-never_type
`#![feature(never_type)]`
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and minor cleanup.
r? lcnr