-
Notifications
You must be signed in to change notification settings - Fork 14k
Reveal opaques defined in the body during analysis #148894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
rustbot has assigned @petrochenkov. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the known-bug comment here and add other annotations to make the test pass (which can include failing compilation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oli-obk Thank you for the feedback. I addressed it in my most recent commit.
This comment has been minimized.
This comment has been minimized.
|
cc @rust-lang/wg-const-eval These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha, @lolbinarycat Some changes occurred in compiler/rustc_codegen_ssa
cc @Muscraft Some changes occurred in exhaustiveness checking cc @Nadrieril The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
ffa1cd3 to
90c3bca
Compare
|
Some changes occurred in compiler/rustc_codegen_gcc |
This comment has been minimized.
This comment has been minimized.
17f4306 to
de7b3b2
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
35d050c to
df42e35
Compare
| .as_local() | ||
| .map_or(ty::TypingMode::non_body_analysis(), |local_def_id| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when do we have non-local DefIds here?
| } | ||
| if self.typing_env.typing_mode.may_define_opaque_types() { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? This means we're now checking less things. Given that the typing env now correctly reveals opauqes, why do we need either the old or the new check? I would expect the change in TypingEnv to remove the need for both
This PR fixes #148094 by revealing the opaque types defined in the body (if any) during mir analysis.