Skip to content

resolve: Consider traits from shadowed glob imports to be in scope #148943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

resolve: Consider traits from shadowed glob imports to be in scope #148943

wants to merge 1 commit into from
+34 −49

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Nov 14, 2025

Closes #144993.

TODO: this needs a crater run first of all.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@petrochenkov
Copy link
Contributor Author

petrochenkov commented Nov 14, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Nov 14, 2025
@rust-bors
Auto merge of #148943 - petrochenkov:traitglobshadow, r=<try>
213ba58 
resolve: Consider traits from shadowed glob imports to be in scope
@petrochenkov petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2025
@petrochenkov petrochenkov mentioned this pull request Nov 14, 2025
Open
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Nov 14, 2025

I'll better run crater on #148946, because it includes this changes as a subset.
@rustbot blocked

@rustbot rustbot added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Nov 14, 2025
@petrochenkov petrochenkov removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 14, 2025
@rust-bors
Copy link

rust-bors bot commented Nov 14, 2025

☀️ Try build successful (CI)
Build commit: 213ba58 (213ba58857e42241934d114390dfcd0779fc4662, parent: c880acdd3171dfafdb55be8cd9822a857e99348d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnr lcnr

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

shadowed traits from glob imports in the same scope get ignored

3 participants

@petrochenkov @rustbot @lcnr