Skip to content

Conversation

@JonathanBrouwer
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer commented Nov 27, 2025

Fixes #149090

Ideally I'd have liked to fix this issue using #149215, and this is still the long term plan, but this is slightly more annoying to implement than I'd have liked to, and this is also a nice and easy solution to the problem.

r? @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 27, 2025
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. r=me after addressing the comment

View changes since this review

@JonathanBrouwer
Copy link
Contributor Author

@bors r=Urgau rollup

@bors
Copy link
Collaborator

bors commented Nov 27, 2025

📌 Commit 41900f8 has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2025
bors added a commit that referenced this pull request Nov 28, 2025
Rollup of 5 pull requests

Successful merges:

 - #149087 (Stabilize `unchecked_neg` and `unchecked_shifts`)
 - #149107 (rustc_borrowck: Don't suggest changing closure param type not under user control)
 - #149323 (Use cg_llvm's target_config in miri)
 - #149380 (Run `eval_config_entry` on all branches so we always emit lints)
 - #149394 (add regression test for guard patterns liveness ICE)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 145c81d into rust-lang:main Nov 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 28, 2025
rust-timer added a commit that referenced this pull request Nov 28, 2025
Rollup merge of #149380 - JonathanBrouwer:cfg_select_lints, r=Urgau

Run `eval_config_entry` on all branches so we always emit lints

Fixes #149090

Ideally I'd have liked to fix this issue using #149215, and this is still the long term plan, but this is slightly more annoying to implement than I'd have liked to, and this is also a nice and easy solution to the problem.

r? `@tgross35`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Nov 28, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#149087 (Stabilize `unchecked_neg` and `unchecked_shifts`)
 - rust-lang/rust#149107 (rustc_borrowck: Don't suggest changing closure param type not under user control)
 - rust-lang/rust#149323 (Use cg_llvm's target_config in miri)
 - rust-lang/rust#149380 (Run `eval_config_entry` on all branches so we always emit lints)
 - rust-lang/rust#149394 (add regression test for guard patterns liveness ICE)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Dec 1, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#149087 (Stabilize `unchecked_neg` and `unchecked_shifts`)
 - rust-lang/rust#149107 (rustc_borrowck: Don't suggest changing closure param type not under user control)
 - rust-lang/rust#149323 (Use cg_llvm's target_config in miri)
 - rust-lang/rust#149380 (Run `eval_config_entry` on all branches so we always emit lints)
 - rust-lang/rust#149394 (add regression test for guard patterns liveness ICE)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cfg_select should check for unexpected_cfgs on other arms

5 participants