Fix name() functions for local defs in rustc_public

[celinval]

This change fixes the behavior of the name() function for CrateDef and Instance which should return absolute path of items. For local items, the crate name was missing.

This resolves: rust-lang/project-stable-mir#109

[rustbot]

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[celinval]

It looks like I need to do some debugging. It's not clear to me why this change affected these tests. I.e., why:

std::task::Poll::Ready -> Poll::Ready
std::option::Option::None -> Option::None

It seems to only affect std ADTs variants.

EDIT: Looking at the pretty print file, before this change, the types Option and Arguments did not include absolute path, but the variant std::option::Option::None did. This uses display not path.

[rustbot]

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

[oli-obk]

You removed with_no_trimmed_paths. If an import in a file exists that allows accessing sth via a shorter path, it gets trimmed. Std is always imported, and some types are also in the prelude. Those always get trimmed

[celinval]

You removed with_no_trimmed_paths. If an import in a file exists that allows accessing sth via a shorter path, it gets trimmed. Std is always imported, and some types are also in the prelude. Those always get trimmed

Thanks @oli-obk. So how should I use with_resolve_crate_name ? Do I need to use it together with with_no_trimmed_path?

[celinval]

Beautiful. @oli-obk it worked like a charm. I changed the pretty printer to use trimmed_name to make it less verbose. Thanks!

[makai410]

Seems like this PR also fixes rust-lang/project-stable-mir#41?

[celinval]

Seems like this PR also fixes rust-lang/project-stable-mir#41?

Good question. I haven't tried it yet