Skip to content

add test for issue 143821 #149413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2025
Merged

add test for issue 143821 #149413

merged 2 commits into from
Nov 28, 2025
+39 −0

Conversation

@Aditya-PS-05
Copy link
Contributor

@Aditya-PS-05 Aditya-PS-05 commented Nov 28, 2025 •
edited by rustbot
Loading

closes #143821

@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Aditya-PS-05 Aditya-PS-05 marked this pull request as draft November 28, 2025 10:54
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025
@Aditya-PS-05 Aditya-PS-05 force-pushed the test-issue-143821-nested-closure-ice branch from 101f13e to 57f9269 Compare November 28, 2025 11:02
@Aditya-PS-05 Aditya-PS-05 marked this pull request as ready for review November 28, 2025 11:02
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2025
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 28, 2025 •
edited
Loading

Could you move this to somewhere outside of tests/issues, and give the test a more descriptive name? Maybe tests/borrowck?
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Aditya-PS-05
Copy link
Contributor Author

Aditya-PS-05 commented Nov 28, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2025
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 28, 2025 •
edited
Loading

@bors r+ rollup
Thanks a lot!

@bors
Copy link
Collaborator

bors commented Nov 28, 2025

📌 Commit 2b4b02e has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 28, 2025
Merged
bors added a commit that referenced this pull request Nov 28, 2025
@bors
Auto merge of #149419 - matthiaskrgr:rollup-v3q93fq, r=matthiaskrgr
089bfa2 
Rollup of 6 pull requests

Successful merges:

 - #147952 (Add a timeout to the `remote-test-client` connection)
 - #149321 (Fix ICE when include_str! reads binary files)
 - #149398 (add regression test for issue #143987)
 - #149411 (Tidying up UI tests [5/N])
 - #149413 (add test for issue 143821)
 - #149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 28, 2025
@bors
Auto merge of #149419 - matthiaskrgr:rollup-v3q93fq, r=matthiaskrgr
cc3eee7 
Rollup of 6 pull requests

Successful merges:

 - #147952 (Add a timeout to the `remote-test-client` connection)
 - #149321 (Fix ICE when include_str! reads binary files)
 - #149398 (add regression test for issue #143987)
 - #149411 (Tidying up UI tests [5/N])
 - #149413 (add test for issue 143821)
 - #149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 60e46fb into rust-lang:main Nov 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 28, 2025
rust-timer added a commit that referenced this pull request Nov 28, 2025
@rust-timer
Unrolled build for #149413
fdc6132 
Rollup merge of #149413 - Aditya-PS-05:test-issue-143821-nested-closure-ice, r=JonathanBrouwer

add test for issue 143821

closes #143821
@Aditya-PS-05
Copy link
Contributor Author

Aditya-PS-05 commented Nov 29, 2025

@bors r+ rollup Thanks a lot!

I am looking to contribute to rust-lang more. Can I get some more advance guide about the structure and design of rustc? If you allow me, I will message on zulip.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 29, 2025
@bors
Auto merge of #149419 - matthiaskrgr:rollup-v3q93fq, r=matthiaskrgr
5f476c2 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#147952 (Add a timeout to the `remote-test-client` connection)
 - rust-lang/rust#149321 (Fix ICE when include_str! reads binary files)
 - rust-lang/rust#149398 (add regression test for issue rust-lang/rust#143987)
 - rust-lang/rust#149411 (Tidying up UI tests [5/N])
 - rust-lang/rust#149413 (add test for issue 143821)
 - rust-lang/rust#149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Crash when compiling an event handler implementation with latest stable rustc 1.88.0

4 participants

@Aditya-PS-05 @rustbot @JonathanBrouwer @bors