Skip to content

Add a regression test for issue 129865 #149421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2025
Merged

Add a regression test for issue 129865 #149421

merged 1 commit into from
Nov 29, 2025
+14 −0

Conversation

@ShoyuVanilla
Copy link
Member

@ShoyuVanilla ShoyuVanilla commented Nov 28, 2025 •
edited by rustbot
Loading

Closes #129865

Looks like the previous versions (< 1.85.0) failed to normalize async block's upvar types containing constants but not anymore

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2025

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@chenyukang
Copy link
Member

chenyukang commented Nov 29, 2025

Thanks!
@bors r=chenyukang

@bors
Copy link
Collaborator

bors commented Nov 29, 2025

📌 Commit c6b0f78 has been approved by chenyukang

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2025
@jhpratt jhpratt mentioned this pull request Nov 29, 2025
Merged
bors added a commit that referenced this pull request Nov 29, 2025
@bors
Auto merge of #149441 - jhpratt:rollup-4hmqc0z, r=jhpratt
3c5c558 
Rollup of 5 pull requests

Successful merges:

 - #147362 (Avoid suggesting constrain the associated type with unknown type)
 - #149395 (float::minimum/maximum: say which exact IEEE operation this corresponds to)
 - #149396 (Remove outdated comment)
 - #149421 (Add a regression test for issue 129865)
 - #149424 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0b94bc0 into rust-lang:main Nov 29, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 29, 2025
rust-timer added a commit that referenced this pull request Nov 29, 2025
@rust-timer
Unrolled build for #149421
64b5499 
Rollup merge of #149421 - ShoyuVanilla:regression-129865, r=chenyukang

Add a regression test for issue 129865

Closes #129865

Looks like the previous versions (`< 1.85.0`) failed to normalize async block's upvar types containing constants but not anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@eholk eholk

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

async code fails to compile with -Znext-solver

5 participants

@ShoyuVanilla @rustbot @chenyukang @bors @eholk