-
Notifications
You must be signed in to change notification settings - Fork 14.1k
Move the libgccjit.so file in a target directory #149426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Since GCC is not multi-target, we need multiple libgccjit.so. Our solution to have a directory per target so that we can have multiple libgccjit.so.
|
This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp. Some changes occurred in compiler/rustc_codegen_gcc |
|
|
This comment has been minimized.
This comment has been minimized.
| let dst = directory.join(target_filename); | ||
| let dest_dir = directory.join(self.target); | ||
| t!(fs::create_dir_all(&dest_dir)); | ||
| let dst = dest_dir.join(target_filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be in lib/rustlib/$target/lib, not lib/$target. Putting it in the latter would cause /usr/lib to contain both x86_64-linux-gnu (from the distro itself) and x86_64-unknown-linux-gnu (from rustc, containing just libgccjit.so) when installing rustc system wide.
This comment has been minimized.
This comment has been minimized.
1fea3d0 to
3dc76dc
Compare
|
This PR modifies |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bjorn3: Is there any way to bless the UI tests for Aarch64 from an x86 computer? |
Since GCC is not multi-target, we need multiple libgccjit.so. Our solution to have a directory per target so that we can have multiple libgccjit.so.
r? @Kobzol