Tidying up UI tests [6/N] #149443
Tidying up UI tests [6/N] #149443
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Since there was only one test in the trait-object directory (and it wasn't in README.md), I moved it to traits/object.
| fn changer<'a>(mut things: Box<dyn Iterator<Item = &'a mut u8>>) { | ||
| for item in *things { | ||
| //~^ ERROR `dyn Iterator<Item = &'a mut u8>` is not an iterator | ||
| *item = 0 | ||
| } | ||
| } |
There was a problem hiding this comment.
I have a quastion.
Can it be considered the same as for-loop-while/iter-from-mac-call.rs and traits/dyn-iterator-deref-in-for-loop?
When this test was first added, there were no special flags. 3a62590
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
rustbot
added
A-rustc-dev-guide
This comment has been minimized.
This comment has been minimized.
|
ooops sorry rebase mistake |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot label -A-rustc-dev-guide -A-testsuite |
rustbot
removed
A-rustc-dev-guide
4 participants
Note
Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.
part of #133895
removed directory
tests/ui/trait-objects,tests/ui/for,tests/ui/warningstrait-objects->traits/objectfor->for-loop-while(exceptfor/issue-20605.rstest. this relocated totraits/dyn-iterator-deref-in-for-loop.rs)warnings->resolve,entry-pointr? Kivooeo