Skip to content

gnullvm hosts: add to build-manifest #149503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

gnullvm hosts: add to build-manifest #149503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/tools/build-manifest/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,23 @@ static DOCS_FALLBACK: &[(&str, &str)] = &[
];

static MSI_INSTALLERS: &[&str] = &[
"aarch64-pc-windows-gnullvm",
"aarch64-pc-windows-msvc",
"i686-pc-windows-gnu",
"i686-pc-windows-msvc",
"x86_64-pc-windows-gnu",
"x86_64-pc-windows-gnullvm",
"x86_64-pc-windows-msvc",
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reasonably replace this with just "target contains windows in the name" or something like that?

I'd like to drive down the need for these to be here similar to how we moved the tier information into rustc itself.

Copy link
Member Author

@mati865 mati865 Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd have to be something along target.contains("windows") && target.has_host_tools().

I think it should be possible to utilise HOSTS array from your recent PR for that.

];

static PKG_INSTALLERS: &[&str] = &["x86_64-apple-darwin", "aarch64-apple-darwin"];

static MINGW: &[&str] = &["i686-pc-windows-gnu", "x86_64-pc-windows-gnu"];
static MINGW: &[&str] = &[
"aarch64-pc-windows-gnullvm",
"i686-pc-windows-gnu",
"x86_64-pc-windows-gnu",
"x86_64-pc-windows-gnullvm",
];

static NIGHTLY_ONLY_COMPONENTS: &[PkgType] =
&[PkgType::Miri, PkgType::JsonDocs, PkgType::RustcCodegenCranelift];
Expand Down
Loading