Rollup of 9 pull requests #149510
Merged
Rollup of 9 pull requests #149510
+764
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like raw string literals.
Added feature gate, documentation and tests also.
Implement `clamp_magnitude` method for primitive floats & signed integers Tracking issue rust-lang#148519 ACP rust-lang/libs-team#686
stabilize maybe_uninit_slice Tracking issue: rust-lang#63569 Closes: rust-lang#63569 FCP completed: rust-lang#63569 (comment) Removes: ```rs pub const fn slice_as_ptr(this: &[MaybeUninit<T>]) -> *const T; pub const fn slice_as_mut_ptr(this: &mut [MaybeUninit<T>]) -> *mut T; ```
cmse: do not calculate the layout of a type with infer types tracking issue: rust-lang#81391 tracking issue: rust-lang#75835 fixes rust-lang#130104 Don't calculate the layout of a type with an infer type (`_`). This now emits `LayoutError::Unknown`, causing an error similar to when any other calling convention is used in this location. The tests use separate functions because only the first such error in a function body is reported. r? `@davidtwco` (might need some T-types assistance)
Fudge infer vars in the cause code of `Obligation` intentionally Fixes the ICE variant in rust-lang/trait-system-refactor-initiative#245. Fixes rust-lang#142866. The detailed cause is in the test comments. r? `@lcnr`
…Kivooeo Don't suggest unwrap for Result in const close rust-lang#149316 Regarding `const fn` that returns `Result`, we should avoid suggesting unwrapping. The original issue reported cases where types didn't match, but in practice, such suggestions may also appear when methods are not found, so this PR includes a fix for that case as well.
fix(parse): Limit frontmatter fences to 255 dashes Like raw string literals. As discussed on rust-lang#148051. Part of rust-lang#136889
…l, r=petrochenkov make assoc fn inherit const stability from inherent `const impl` blocks Pulled out of rust-lang#147893, "Currently, one cannot add any const stability annotations on the individual assoc fns at all, as the specific pass that checks for const stability on const fn seems to run as a HIR visitor [and looks at HIR assoc fn constness, which should be changed to also look at its parent]. I suspect there are things to be cleaned up there." I was slightly lazy so didn't add the "staged_api using staged_api in implicit const stable context, in const unstable context, in explicit const stable context" tests. nudge me if you want to see those!
Fix indent in E0591.md It currently looks like this. <img width="1389" height="595" alt="image" src="https://github.com/user-attachments/assets/5336eebd-42a6-43c6-9127-9278cd82a9c2" /> https://doc.rust-lang.org/nightly/error_codes/E0591.html So I can't run it, and the copied code has `#` in front.
…ochenkov Fix rust-lang#148889: Add label rib when visiting delegation body This PR relates to the delegation feature rust-lang#118212, it fixes rust-lang#148889 ICE. r? `@petrochenkov`
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 2fb805367d In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 2fb8053 (parent) -> a463b0e (this PR) Test differencesShow 942 test diffsStage 0
Stage 1
Stage 2
(and 512 additional test diffs) Additionally, 330 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a463b0e2ee07b232221afd8475bc8f4d7d474609 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (a463b0e): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -3.5%, secondary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 4.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 471.488s -> 471.474s (-0.00%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
clamp_magnitudemethod for primitive floats & signed integers #148690 (Implementclamp_magnitudemethod for primitive floats & signed integers)Obligationintentionally #149299 (Fudge infer vars in the cause code ofObligationintentionally)const implblocks #149445 (make assoc fn inherit const stability from inherentconst implblocks)no entry found for keyincompiler/rustc_ast_lowering/src/expr.rs#148889: Add label rib when visiting delegation body)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup