Skip to content

Implement blessing for tidy alphabetical check #149517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Implement blessing for tidy alphabetical check #149517

wants to merge 6 commits into from
+298 −96

Conversation

@WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Dec 1, 2025

@WaffleLapkin
add a tidy test
bfbe4d4
@WaffleLapkin
refactor tidy alphabetical lint
3cb12f4 
This slightly changes alphabetical lint semantics...
specifically if an "item" is multiline (when the next line
does not have the same indentation) we now consider all lines (ignoring
starting whitespace) for ordering, not just the first one.
@WaffleLapkin
implement tidy bless for alphabetical blocks
2f8e402
@WaffleLapkin
bless tidy tests
d9fc9e2
@WaffleLapkin
drive-by: tidy: fixup style
fedf9bc
@WaffleLapkin
bless tidy
4edf265
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WaffleLapkin @rustbot @jdonszelmann