Rename supertrait item shadowing lints #149532
Open
+47
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
lqd
reviewed
Dec 2, 2025
| /// silently, this lint detects these cases when users want to deny them | ||
| /// or fix the call sites. | ||
| pub SUPERTRAIT_ITEM_SHADOWING_USAGE, | ||
| pub RESOLVING_TO_ITEMS_SHADOWING_SUPERTRAIT_ITEMS, |
Member
There was a problem hiding this comment.
Ah the #![deny(supertrait_item_shadowing_usage)] in the doc example above should also be changed to #![deny(resolving_to_items_shadowing_supertrait_items)]
lqd
reviewed
Dec 2, 2025
| /// silently, this lint detects these cases when users want to deny them | ||
| /// or fix their trait definitions. | ||
| pub SUPERTRAIT_ITEM_SHADOWING_DEFINITION, | ||
| pub SHADOWING_SUPERTRAIT_ITEMS, |
Member
There was a problem hiding this comment.
Same issue here for the #![deny(supertrait_item_shadowing_definition)] above.
Member
|
r? lqd, r=me when CI is green |
Amanieu
force-pushed
the
supertrait-shadowing-lints
branch
from
6e3af4c to
e833f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the lang team decision here and renames:
supertrait_item_shadowing_definitiontoshadowing_supertrait_itemssupertrait_item_shadowing_usagetoresolving_to_items_shadowing_supertrait_itemsThe lint levels are left unchanged as allow-by-default until stabilization.