fix the check for which expressions read never type #149545
Open
+226
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
type_ascribe2
branch
from
70c9a97 to
948d10b
Compare
This comment has been minimized.
This comment has been minimized.
…ed_to_constitute_read_for_never` to more accessible locations
...wrt `type_ascribe`/unsafe binders -- the check was infinitely recursive before.
... since unreachable-code only has a few tests while `reachable` is the more popular directory...
WaffleLapkin
force-pushed
the
type_ascribe2
branch
from
948d10b to
4736576
Compare
jackh726
reviewed
Dec 2, 2025
Comment on lines
+1810
to
+1811
| // Might not constitute a read, since the condition might be false. | ||
| PatKind::Guard(_, _) => true, |
Member
There was a problem hiding this comment.
A drive-by thought: this comment doesn't seem to match the function? From the comment, the expectation is false, given the function is guaranteed but this comment just it's not guaranteed.
| @@ -0,0 +1,17 @@ | |||
| // Regression test for <https://github.com/rust-lang/rust/issues/149431> | |||
Member
There was a problem hiding this comment.
In the previous commit, you moved tests from unreachable-code to reachable, but this test is in unreachable-code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149542
Fixes #149431
First commit is a drive-by needed for the refactor of the unreachable code lint, see #148303