library: Rename IterRange* to Range*Iter
#149547
Open
+36
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
tgross35
removed
the
T-compiler
This comment has been minimized.
This comment has been minimized.
tgross35
force-pushed
the
range-iterators
branch
from
199cebb to
6c51fb1
Compare
13 tasks
There is a weak convention in the ecosystem that `IterFoos` is an iterator yielding items of type `Foo` (e.g. `bitflags` `IterNames`, `hashbrown` `IterBuckets`), while `FooIter` is an iterator over `Foo` from an `.iter()` or `.into_iter()` method (e.g. `memchr` `OneIter`, `regex` `SetMatchesIter`). Rename `IterRange`, `IterRangeInclusive`, and `IterRangeFrom` to `RangeIter`, `RangeInclusiveIter`, and `RangeInclusiveIter` to match this. Tracking issue: RUST-125687 (`new_range_api`)
tgross35
force-pushed
the
range-iterators
branch
from
6c51fb1 to
bb239c2
Compare
Contributor
Author
|
(accepted by libs-api in #125687 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a weak convention in the ecosystem that
IterFoosis an iterator yielding items of typeFoo(e.g.bitflagsIterNames,hashbrownIterBuckets), whileFooIteris an iterator overFoofrom an.iter()or.into_iter()method (e.g.memchrOneIter,regexSetMatchesIter). RenameIterRange,IterRangeInclusive, andIterRangeFromtoRangeIter,RangeInclusiveIter, andRangeInclusiveIterto match this.Tracking issue: #125687 (
new_range_api)