Disable native-lib for x check miri #149550
Open
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces check times for miri from 2m15s to 20s. And reduces check times for miri with --compile-time-deps from 1m50s to 7s. This makes rust-analyzer start a lot faster after switching branches.
rustbot
added
S-waiting-on-review
Member
|
Thanks! The genmc-sys things being built for Miri were super slow. You can r=me once PR CI passes. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
genmc-sys is off-by-default, this is different. However, I'm not super happy about this as it means the native-lib code doesn't get checked, and sometimes one has to work on that code. Ideally we'd still check it, we'd just skip building the C dependency. libffi-sys has a feature for that since libffi-rs/libffi-rs#166, could we make use of that? capstone-sys has a similar feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces check times for miri from 2m15s to 20s. And reduces check times for miri with --compile-time-deps from 1m50s to 7s. This makes rust-analyzer start a lot faster after switching branches.
r? @RalfJung