Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 3, 2025

Pulls in rust-lang/reference#2080 to fix the tests.

Closes #149575

Pulls in rust-lang/reference#2080 to fix the tests.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 3, 2025

⚠️ Warning ⚠️

@ehuss
Copy link
Contributor Author

ehuss commented Dec 3, 2025

@bors r+ p=1000

@bors
Copy link
Collaborator

bors commented Dec 3, 2025

📌 Commit 880a779 has been approved by ehuss

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 3, 2025

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2025
@bors
Copy link
Collaborator

bors commented Dec 3, 2025

⌛ Testing commit 880a779 with merge 672388e...

@bors
Copy link
Collaborator

bors commented Dec 3, 2025

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 672388e to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2025
@bors bors merged commit 672388e into rust-lang:main Dec 3, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Dec 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a4cfac7 (parent) -> 672388e (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 672388edbee9e93c35e5fdf7dac818a6612a5103 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-llvm-20: 2778.8s -> 2236.4s (-19.5%)
  2. armhf-gnu: 5457.1s -> 4566.8s (-16.3%)
  3. dist-apple-various: 3957.5s -> 4600.2s (+16.2%)
  4. pr-check-1: 1933.0s -> 1622.0s (-16.1%)
  5. x86_64-rust-for-linux: 3097.1s -> 2670.7s (-13.8%)
  6. dist-aarch64-msvc: 5479.1s -> 6193.6s (+13.0%)
  7. x86_64-gnu-gcc: 3446.2s -> 3006.0s (-12.8%)
  8. dist-x86_64-mingw: 9825.1s -> 8650.7s (-12.0%)
  9. x86_64-gnu-miri: 4961.6s -> 4393.1s (-11.5%)
  10. aarch64-gnu-llvm-20-1: 3603.4s -> 3194.2s (-11.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 3, 2025

@/bors treeclosed-

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (672388e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Max RSS (memory usage)

Results (primary -1.0%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Cycles

Results (secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.9% [-3.9%, -3.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.504s -> 469.113s (0.34%)
Artifact size: 386.75 MiB -> 386.77 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

src/doc/reference doctests is failing in PR CI

6 participants