Skip to content

cg_gcc subtree update #149642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 16 commits into from
Dec 4, 2025
Merged

cg_gcc subtree update #149642

bors merged 16 commits into from
Dec 4, 2025
+322 −276

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Dec 4, 2025

cc @antoyo

r? ghost

dvermd and others added 16 commits November 17, 2025 09:42
@dvermd
fix 128bit ctlz intrinsic UB
485b53c
@dvermd
fix 128bit cttz intrinsic UB
e4fd312
@dvermd
factorize count leading and trailing zeros code
8f21e24
@dvermd
add ctlz and cttz tests
d702363
@dvermd
add ubsan to Debug test Profile
a9b15b6
@antoyo
Use generic builtin for checked binary operation
364af52
@antoyo
Merge pull request rust-lang#809 from rust-lang/generic-checked-binop
05af078 
Use generic builtin for checked binary operation
@antoyo
Use generic builtin for saturating add/sub
c1f50c0
@antoyo
Merge pull request rust-lang#810 from rust-lang/generic-checked-binop
55bd9bf 
Use generic builtin for saturating add/sub
@antoyo
Merge pull request rust-lang#635 from dvermd/fix_128b_leading_zeros_ub
c3c8a9a 
fix 128bits ctlz intrinsincs UB
@harin-ramesh @FrancescoV1985 @antoyo
Better document some combinations of flags (rust-lang#808)
b87bfdc 
---------

Co-authored-by: FrancescoV1985 <franci.vi@tiscali.it>
Co-authored-by: FrancescoV1985 <62872737+FrancescoV1985@users.noreply.github.com>
Co-authored-by: antoyo <antoyo@users.noreply.github.com>
@antoyo
Use fallback sysroot directory if we cannot find libgccjit.so in the …
2da3314 
…explicit directory
@antoyo
Merge pull request rust-lang#811 from rust-lang/fix/use-fallback-sysroot
df9894b 
Use fallback sysroot directory if we cannot find libgccjit.so in the explicit directory
@antoyo
Update gccjit_sys
ed64abc
@antoyo
Merge pull request rust-lang#812 from rust-lang/update/gccjit_sys
dab6863 
Update gccjit_sys
@GuillaumeGomez
Merge commit 'dab6863ce82346cf56c88b6f90a146200358207f' into subtree-…
94f1bfe 
…update_cg_gcc_2025-12-04
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Dec 4, 2025

@bors r+ p=1 rollup=never

@bors
Copy link
Collaborator

bors commented Dec 4, 2025

📌 Commit 94f1bfe has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2025
@bors
Copy link
Collaborator

bors commented Dec 4, 2025

⌛ Testing commit 94f1bfe with merge b33119f...

@bors
Copy link
Collaborator

bors commented Dec 4, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing b33119f to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2025
@bors bors merged commit b33119f into rust-lang:main Dec 4, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 29e035e (parent) -> b33119f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b33119ffdd483969934b10a886dc06dd29a473f9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-msvc: 7073.5s -> 12370.9s (+74.9%)
  2. dist-apple-various: 4270.7s -> 5060.2s (+18.5%)
  3. dist-aarch64-llvm-mingw: 7016.9s -> 5916.6s (-15.7%)
  4. pr-check-1: 1973.8s -> 1694.3s (-14.2%)
  5. x86_64-gnu-tools: 3756.8s -> 3242.5s (-13.7%)
  6. dist-s390x-linux: 4877.5s -> 5532.7s (+13.4%)
  7. x86_64-gnu: 7150.5s -> 6204.1s (-13.2%)
  8. i686-gnu-2: 6176.9s -> 5394.3s (-12.7%)
  9. x86_64-gnu-llvm-20: 2747.4s -> 2441.4s (-11.1%)
  10. aarch64-gnu-llvm-20-1: 3868.1s -> 3458.6s (-10.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@GuillaumeGomez GuillaumeGomez deleted the subtree-update_cg_gcc_2025-12-04 branch December 4, 2025 22:11
@bors bors mentioned this pull request Dec 4, 2025
Open
@rust-timer
Copy link
Collaborator

rust-timer commented Dec 5, 2025

Finished benchmarking commit (b33119f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.646s -> 470.287s (-0.08%)
Artifact size: 386.77 MiB -> 386.77 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antoyo antoyo antoyo approved these changes

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GuillaumeGomez @rustbot @bors @rust-timer @antoyo @dvermd @harin-ramesh