Skip to content

crate::io::Result → io::Result in most places #149778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tbu- wants to merge 1 commit into
base: main
Choose a base branch
from
Open

crate::io::Result → io::Result in most places #149778

tbu- wants to merge 1 commit into from
+115 −123

Conversation

@tbu-
Copy link
Contributor

@tbu- tbu- commented Dec 8, 2025

I don't know why many places refer to the type as crate::io::Result when crate::io is already imported.

@rustbot rustbot added O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 8, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tbu-
crate::io::Result → io::Result in most places
09e39c6 
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
@tbu- tbu- force-pushed the pr_crate_io_result branch from 99eb90b to 09e39c6 Compare December 8, 2025 17:46
@tbu-
Copy link
Contributor Author

tbu- commented Dec 8, 2025

How do I verify that I haven't broken all of these targets that the CI doesn't check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

O-hermit Operating System: Hermit O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tbu- @rustbot @rust-log-analyzer @Mark-Simulacrum