Move shared offload globals and define per-kernel globals once #149788
+160
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
Sa4dUs
force-pushed
the
offload-cleanup
branch
from
9de91f2 to
b357e0c
Compare
Sa4dUs
commented
Dec 8, 2025
| if cx.sess().opts.unstable_opts.offload.contains(&Offload::Enable) | ||
| && !cx.sess().target.is_like_gpu | ||
| { | ||
| cx.offload_globals.replace(Some(OffloadGlobals::declare(&cx))); |
Contributor
Author
There was a problem hiding this comment.
i'm a bit unsure about this location. we could also cache these globals and generate them on the first intrinsic call, but that felt like overloading intrinsic codegen a bit too much
i don't have a strong opinion though, so happy to go with whatever u think is best
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the shared LLVM global variables logic out of the
offloadintrinsic codegen and generates kernel-specific variables only ont he first call of the intrinsic.r? @ZuseZ4