Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDeprecate advance method on Iterators. #15514
Conversation
This comment has been minimized.
This comment has been minimized.
|
This should theoretically |
luqmana
changed the title
Remove advance from Iterator.
Deprecate advance method on Iterators,
Jul 7, 2014
luqmana
changed the title
Deprecate advance method on Iterators,
Deprecate advance method on Iterators.
Jul 7, 2014
bors
added a commit
that referenced
this pull request
Jul 8, 2014
bors
added a commit
that referenced
this pull request
Jul 9, 2014
luqmana
added some commits
Jun 12, 2014
This comment has been minimized.
This comment has been minimized.
cmr
commented on 5d39d0b
Jul 9, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from cmr |
This comment has been minimized.
This comment has been minimized.
|
merging luqmana/rust/die-advance-die = 5d39d0b into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 1b8e671 |
bors
added a commit
that referenced
this pull request
Jul 9, 2014
bors
closed this
Jul 10, 2014
luqmana
deleted the
luqmana:die-advance-die
branch
Jul 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
luqmana commentedJul 7, 2014
Closes #15492.