Convert strict_provenance_lints to late lint passes#156862
Open
hanna-kruppe wants to merge 2 commits into
Open
Convert strict_provenance_lints to late lint passes#156862hanna-kruppe wants to merge 2 commits into
hanna-kruppe wants to merge 2 commits into
Conversation
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
hanna-kruppe
commented
May 23, 2026
Contributor
Author
There was a problem hiding this comment.
I'm not sure if it makes sense to keep this test. From the information in #137588 it seems like:
- The lint running and emitting a diagnostic is somehow a load-bearing part of the reproduction, so this test likely won't work as regression test any more with the changes in this PR.
- Nobody ever pinned down the root cause of the ICE, figured out which change fixed it, or found a reproduction that doesn't trigger a bunch of other compiler errors along the way.
I don't know how to update the test so it still has a chance of being useful as a regression test. And it doesn't seem like there's anyone who understood #137588 well enough to help with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, these lints run during type checking of cast expressions, but they work fine as regular late lint passes, so this PR converts them to passes.
Besides the generic reasons to prefer regular lint passes over "hardwired" lints, the move solves one problem unique to cast type checking: emitting diagnostics directly in
CastCheck::do_checkcauses problems for clippy reusing the cast type checking code.Tracking issue: #130351