Make hint::cold_path #[cold] so that it works even if the MIR inliner can't inline it#156863
Open
saethlin wants to merge 1 commit into
Open
Make hint::cold_path #[cold] so that it works even if the MIR inliner can't inline it#156863saethlin wants to merge 1 commit into
saethlin wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
added
T-compiler
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #156859 because the branch weight metadata is actually keyed off seeing a
#[cold]function call in an arm. We don't need the intrinsic, any#[cold]function will do. So if the hint wrapper itself is made#[cold], we will still get the desired effect, and LLVM will clean up the call to an empty function when optimizations are enabled.