Stop needing an alloca for catch_unwind#156867
Open
scottmcm wants to merge 1 commit into
Open
Conversation
Collaborator
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
scottmcm
force-pushed
the
WIP-no-alloca-for-catch-unwind
branch
from
2a1bb44 to
13ccf4f
Compare
This comment has been minimized.
This comment has been minimized.
scottmcm
force-pushed
the
WIP-no-alloca-for-catch-unwind
branch
from
13ccf4f to
31eb9f4
Compare
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
Turns out these were all making `OperandValue::Immediate`s already -- the intrinsic always returns a primitive scalar -- so pretty easy to handle. While I was looking at it, I also "rustified" the intrinsic signature a bit: returning a `bool` and taking a generic pointee and `unsafe fn`s cleans up the call in `std` a bit without making the implementation in the backend any harder.
scottmcm
force-pushed
the
WIP-no-alloca-for-catch-unwind
branch
from
31eb9f4 to
6adeeb5
Compare
This comment was marked as resolved.
This comment was marked as resolved.
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out these were all making
OperandValue::Immediates already -- the intrinsic always returns a primitive scalar -- so pretty easy to handle.cc #153250 rust-lang/compiler-team#970
While I was looking at it, I also "rustified" the intrinsic signature a bit: returning a
booland taking a generic pointee andunsafe fns cleans up the call instda bit without making the implementation in the backend any harder.r? dianqk