codegen: re-enable FileCheck for scalable-vector tuple intrinsics#156878
Open
qaijuang wants to merge 1 commit into
Open
codegen: re-enable FileCheck for scalable-vector tuple intrinsics#156878qaijuang wants to merge 1 commit into
qaijuang wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
Member
|
I have started reviewing and should finish a pass today because this is light work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FileCheck directives in
tests/codegen-llvm/scalable-vectors/tuple-intrinsics.rswere not actually being checked: the test used//@ build-pass, and #155630 made that explicit by replacing it with//@ skip-filecheck.This fixes the stale checks and re-enables FileCheck for the test. The
getandsetcases now use concrete index-0 wrappers, so they have stable#[no_mangle]names for FileCheck to match.Fixes #155665.
r? @jieyouxu