Rename -Zdebuginfo-for-profiling switch#156887
Open
zamazan4ik wants to merge 2 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
zamazan4ik
force-pushed
the
rename-debuginfo-for-profiling-switch
branch
from
1c4094e to
58d2a68
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
- the test was ported from this commit: llvm/llvm-project@3009211
zamazan4ik
force-pushed
the
rename-debuginfo-for-profiling-switch
branch
from
58d2a68 to
57e7bf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR was raised from this comment from another stabilization PR: #155942
I renamed
-Zdebug-info-for-profilinginto-Zdebuginfo-for-profilingbefore stabilization to be consistent with otherdebuginfo-related Rustc flags like-C split-debuginfoand-C debuginfo.One important note is that Clang has the flag under
-fdebug-info-for-profiling. I decided that consistency with other Rustc flags is more important here than to be consistent with Clang.r? folkertdev (as was proposed here)