Skip to content

compiler-builtins subtree update#157037

Merged
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
tgross35:update-builtins
May 28, 2026
Merged

compiler-builtins subtree update#157037
rust-bors[bot] merged 13 commits into
rust-lang:mainfrom
tgross35:update-builtins

Conversation

@tgross35

@tgross35 tgross35 commented May 27, 2026

Copy link
Copy Markdown
Contributor

Subtree update of compiler-builtins to rust-lang/compiler-builtins@8bf3293.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost

tgross35 and others added 13 commits April 25, 2026 12:23
@tgross35
fma: Clean up unit test cases and add a few more
f8dda89
@tgross35
libm: Add fmaf16
fe9b995
Prepare for merging from rust-lang/rust
bb8d1ef 
This updates the rust-version file to 68ffae4.
Merge ref '68ffae46b581' from rust-lang/rust
3aefc27 
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: rust-lang/rust@68ffae4
Filtered ref: rust-lang/compiler-builtins@7602939
Upstream diff: rust-lang/rust@d0442e2...68ffae4

This merge was created using https://github.com/rust-lang/josh-sync.
@tgross35
docs: Enable unstable-float for docs.rs builds
d90a7d3
@renovate-bot @tgross35
chore(deps): lock file maintenance
68ca598
@DKLoehr
c-b: Avoid a build script panic from .unwrap() (rust-lang#1213)
a5fc7af 
The current code expects CARGO_MANIFEST_DIR to always end in a directory
name, which prevents passing something like ".". We can continue to
support that by unwrapping using `if let` first.

Fixes: rust-lang/compiler-builtins#1187 (comment)
@Hawk777 @tgross35
Fix some typos in comments
798a6fb
@renovate-bot @tgross35
chore(deps): update rust crate gungraun to 0.19.0
86098ec
@tgross35
musl-math-sys: Fix a new clippy lint
65c0774
@tgross35
test: Allow unstable_name_collisions
534a510 
Avoid a new error about `.widen()`.
@Gelbpunkt
symcheck: Only ELFv1 ppc64 doesn't set .note.GNU-stack
79bb9f7 
`powerpc64-unknown-linux-gnu` currently is an ELFv1 target, while
`powerpc64-unknown-linux-musl` is an ELFv2 target.

Big-endian and little-endian ELFv2 targets both behave normally: they emit
`.note.GNU-stack`. Therefore, currently the tests would fail on big-endian
powerpc64 with ELFv2 ABI.

To determine whether we need to special-case powerpc64, we should check
the ABI instead of the endianness. The problem here is that the `e_flags`
part of the ELF header is actually `0` in the output of `cc -O0
-ffunction-sections -fdata-sections -fPIC -m64 -mabi=elfv2 -Wall -Wextra
-o missing_gnu_stack_section.o -c missing_gnu_stack_section.S`, the output
of that command is bit-for-bit identical on ELFv1 and ELFv2 hosts. In
order to know when to allow an unset `.note.GNU-stack` we therefore must
set `.abiversion 2` to be able to tell them apart from the ELF header.

This makes all tests pass on `powerpc64-unknown-linux-musl`.
@Gelbpunkt @tgross35
Upgrade taiki-e/install-action to 2.79.8
628b0b9 
This release includes support for ppc64.
@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 27, 2026
@rustbot

rustbot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

  • This PR is based on an upstream commit that is older than 28 days.

    It's recommended to update your branch according to the rustc-dev-guide.

@tgross35 tgross35 mentioned this pull request May 27, 2026
Merged
@tgross35

tgross35 commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never

@rust-bors

rust-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 628b0b9 has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 28, 2026
@rust-bors

rust-bors Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: tgross35
Duration: 3h 11m 24s
Pushing 8f02e85 to main...

@rust-bors rust-bors Bot merged commit 8f02e85 into rust-lang:main May 28, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone May 28, 2026
@github-actions

github-actions Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 57d0690 (parent) -> 8f02e85 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8f02e856be945d5d879b2ff9b7d19dd6bfb1c0e5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-msvc-1: 2h 6m -> 2h 41m (+27.7%)
  2. dist-ohos-aarch64: 1h 5m -> 52m 26s (-19.8%)
  3. dist-i686-msvc: 2h 13m -> 1h 47m (-19.3%)
  4. i686-gnu-2: 1h 41m -> 1h 22m (-19.0%)
  5. dist-loongarch64-musl: 1h 32m -> 1h 50m (+18.7%)
  6. dist-x86_64-apple: 2h 9m -> 1h 46m (-17.7%)
  7. aarch64-apple: 2h 37m -> 3h 5m (+17.6%)
  8. x86_64-msvc-ext1: 2h 4m -> 1h 43m (-16.7%)
  9. x86_64-msvc-2: 1h 39m -> 1h 55m (+16.3%)
  10. dist-apple-various: 1h 41m -> 1h 26m (-15.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8f02e85): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary 1.9%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.9% [1.9%, 1.9%] 1
Regressions ❌
(secondary)		 4.9% [3.2%, 6.6%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.4% [-2.4%, -2.4%] 1
All ❌✅ (primary) 1.9% [1.9%, 1.9%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 509.533s -> 511.209s (0.33%)
Artifact size: 400.69 MiB -> 400.71 MiB (0.00%)

@tgross35 tgross35 deleted the update-builtins branch May 28, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) merged-by-bors This PR was explicitly merged by bors. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

7 participants

@tgross35 @rustbot @rust-timer @renovate-bot @DKLoehr @Hawk777 @Gelbpunkt