Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide: guessing game #15729

Closed

Conversation

steveklabnik
Copy link
Member

This doesn't rely on #15690 for any code, but does for coherence.

We now build the game at the end of the first section.

I wanted to do it as we went along, but it's too hard with these fundamentals not in place. The rest will do the 'as we go' approach, but I think this is better.

@@ -359,68 +360,9 @@ rest of your Rust career.

Next, we'll learn more about Rust itself, by starting to write a more complicated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph doesn't flow too nicely IMHO in the rewritten version. You said we're going to write a more complicated program next, but then take it right back again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

We now build the game at the end of the first section.

I wanted to do it as we went along, but it's too hard with these fundamentals
not in place. The rest will do the 'as we go' approach, but I think this is
better.
@steveklabnik
Copy link
Member Author

All that stuff should be taken care of now.

bors added a commit that referenced this pull request Jul 21, 2014
This doesn't rely on #15690 for any code, but does for coherence.

We now build the game at the end of the first section.
    
I wanted to do it as we went along, but it's too hard with these fundamentals not in place. The rest will do the 'as we go' approach, but I think this is better.
bors added a commit that referenced this pull request Jul 21, 2014
This doesn't rely on #15690 for any code, but does for coherence.

We now build the game at the end of the first section.
    
I wanted to do it as we went along, but it's too hard with these fundamentals not in place. The rest will do the 'as we go' approach, but I think this is better.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jul 21, 2014
Closes rust-lang#15690 (Guide: improve error handling)
Closes rust-lang#15729 (Guide: guessing game)
Closes rust-lang#15751 (repair macro docs)
Closes rust-lang#15766 (rustc: Print a smaller hash on -v)
Closes rust-lang#15815 (Add unit test for rlibc)
Closes rust-lang#15820 (Minor refactoring and features in rustc driver for embedders)
Closes rust-lang#15822 (rustdoc: Add an --extern flag analagous to rustc's)
Closes rust-lang#15824 (Document Deque trait and bitv.)
Closes rust-lang#15832 (syntax: Join consecutive string literals in format strings together)
Closes rust-lang#15837 (Update LLVM to include NullCheckElimination pass)
Closes rust-lang#15841 (Rename to_str to to_string)
Closes rust-lang#15848 (privacy: Add publically-reexported foreign item to exported item set)
Closes rust-lang#15849 (fix string in from_utf8_lossy_100_multibyte benchmark)
Closes rust-lang#15850 (Get rid of few warnings in tests)
Closes rust-lang#15852 (Clarify the std::vec::Vec::with_capacity docs)
@steveklabnik steveklabnik deleted the guide_guessing_game branch July 21, 2014 23:24
Gankra pushed a commit to Gankra/rust that referenced this pull request Jul 28, 2014
Closes rust-lang#15690 (Guide: improve error handling)
Closes rust-lang#15729 (Guide: guessing game)
Closes rust-lang#15751 (repair macro docs)
Closes rust-lang#15766 (rustc: Print a smaller hash on -v)
Closes rust-lang#15815 (Add unit test for rlibc)
Closes rust-lang#15820 (Minor refactoring and features in rustc driver for embedders)
Closes rust-lang#15822 (rustdoc: Add an --extern flag analagous to rustc's)
Closes rust-lang#15824 (Document Deque trait and bitv.)
Closes rust-lang#15832 (syntax: Join consecutive string literals in format strings together)
Closes rust-lang#15837 (Update LLVM to include NullCheckElimination pass)
Closes rust-lang#15841 (Rename to_str to to_string)
Closes rust-lang#15847 (Purge #[!resolve_unexported] from the compiler)
Closes rust-lang#15848 (privacy: Add publically-reexported foreign item to exported item set)
Closes rust-lang#15849 (fix string in from_utf8_lossy_100_multibyte benchmark)
Closes rust-lang#15850 (Get rid of few warnings in tests)
Closes rust-lang#15852 (Clarify the std::vec::Vec::with_capacity docs)
@huonw huonw mentioned this pull request Sep 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants